You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lokeshj1703 (via GitHub)" <gi...@apache.org> on 2023/03/10 08:53:12 UTC

[GitHub] [hudi] lokeshj1703 opened a new pull request, #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

lokeshj1703 opened a new pull request, #8155:
URL: https://github.com/apache/hudi/pull/8155

   ### Change Logs
   
   Relevant classes:
   
   SqlFileBasedTransformer
   SqlQueryBasedTransformer
   
   The following can be skipped
   
   FlinkClusteringConfig
   FlinkCompactionConfig
   FlinkStreamerConfig
   
   HoodieRealtimeConfig
   HiveSyncConfigHolder
   
   ### Impact
   
   NA
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1472792069

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c24db5815366139661328e57619e44254393e147",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684",
       "triggerID" : "c24db5815366139661328e57619e44254393e147",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4b68aa73415424ed21cb5abe66d47756ed84d733",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15763",
       "triggerID" : "4b68aa73415424ed21cb5abe66d47756ed84d733",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c24db5815366139661328e57619e44254393e147 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684) 
   * 4b68aa73415424ed21cb5abe66d47756ed84d733 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15763) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1465583550

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c24db5815366139661328e57619e44254393e147",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684",
       "triggerID" : "c24db5815366139661328e57619e44254393e147",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c24db5815366139661328e57619e44254393e147 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1465780152

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c24db5815366139661328e57619e44254393e147",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684",
       "triggerID" : "c24db5815366139661328e57619e44254393e147",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c24db5815366139661328e57619e44254393e147 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1472902011

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c24db5815366139661328e57619e44254393e147",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684",
       "triggerID" : "c24db5815366139661328e57619e44254393e147",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4b68aa73415424ed21cb5abe66d47756ed84d733",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15763",
       "triggerID" : "4b68aa73415424ed21cb5abe66d47756ed84d733",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4b68aa73415424ed21cb5abe66d47756ed84d733 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15763) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8155:
URL: https://github.com/apache/hudi/pull/8155#discussion_r1133461106


##########
hudi-common/src/main/java/org/apache/hudi/common/config/ConfigGroups.java:
##########
@@ -37,7 +37,8 @@ public enum Names {
     METRICS("Metrics Configs"),
     RECORD_PAYLOAD("Record Payload Config"),
     KAFKA_CONNECT("Kafka Connect Configs"),
-    AWS("Amazon Web Services Configs");
+    AWS("Amazon Web Services Configs"),
+    DELTA_STREAMER("DeltaStreamer Configs");

Review Comment:
   Remove the change from #8152?



##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieDeltaStreamerConfig.java:
##########
@@ -93,6 +93,16 @@ public class HoodieDeltaStreamerConfig extends HoodieConfig {
       .withDocumentation("The path to which a particular table is ingested. The config is specific to HoodieMultiTableDeltaStreamer"
           + " and overrides path determined using option `--base-path-prefix` for a table");
 
+  public static final ConfigProperty<String> TRANSFORMER_SQL_FILE = ConfigProperty

Review Comment:
   Let's add transformer configs into a separate config class `DeltaStreamerTransformerConfig`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1478753240

   CI passes.
   <img width="1618" alt="Screenshot 2023-03-21 at 17 16 01" src="https://user-images.githubusercontent.com/2497195/226770006-d0b83f46-5ee9-4830-b465-abf5b0a2914b.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8155:
URL: https://github.com/apache/hudi/pull/8155#discussion_r1142771441


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/SqlTransformerConfig.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.utilities.config;
+
+import org.apache.hudi.common.config.ConfigClassProperty;
+import org.apache.hudi.common.config.ConfigGroups;
+import org.apache.hudi.common.config.ConfigProperty;
+import org.apache.hudi.common.config.HoodieConfig;
+
+import javax.annotation.concurrent.Immutable;
+
+/**
+ * DeltaStreamer SQL Transformer Configs
+ */
+@Immutable
+@ConfigClassProperty(name = "DeltaStreamer SQL Transformer Configs",
+    groupName = ConfigGroups.Names.DELTA_STREAMER,

Review Comment:
   how are we envisioning the configs for diff sources in Deltastreamer? I don't think we can have one config class per source. 



##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/SqlTransformerConfig.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.utilities.config;
+
+import org.apache.hudi.common.config.ConfigClassProperty;
+import org.apache.hudi.common.config.ConfigGroups;
+import org.apache.hudi.common.config.ConfigProperty;
+import org.apache.hudi.common.config.HoodieConfig;
+
+import javax.annotation.concurrent.Immutable;
+
+/**
+ * DeltaStreamer SQL Transformer Configs
+ */
+@Immutable
+@ConfigClassProperty(name = "DeltaStreamer SQL Transformer Configs",
+    groupName = ConfigGroups.Names.DELTA_STREAMER,

Review Comment:
   is this DELTA_STREAMER config or DELTA_STREAMER_SQL_TRANSFORMER_CONFIG? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8155:
URL: https://github.com/apache/hudi/pull/8155#discussion_r1142772738


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/SqlTransformerConfig.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.utilities.config;
+
+import org.apache.hudi.common.config.ConfigClassProperty;
+import org.apache.hudi.common.config.ConfigGroups;
+import org.apache.hudi.common.config.ConfigProperty;
+import org.apache.hudi.common.config.HoodieConfig;
+
+import javax.annotation.concurrent.Immutable;
+
+/**
+ * DeltaStreamer SQL Transformer Configs
+ */
+@Immutable
+@ConfigClassProperty(name = "DeltaStreamer SQL Transformer Configs",
+    groupName = ConfigGroups.Names.DELTA_STREAMER,

Review Comment:
   oh, my bad. group name is DELTA_STREAMER. makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8155:
URL: https://github.com/apache/hudi/pull/8155#discussion_r1139352811


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieDeltaStreamerConfig.java:
##########
@@ -93,6 +93,16 @@ public class HoodieDeltaStreamerConfig extends HoodieConfig {
       .withDocumentation("The path to which a particular table is ingested. The config is specific to HoodieMultiTableDeltaStreamer"
           + " and overrides path determined using option `--base-path-prefix` for a table");
 
+  public static final ConfigProperty<String> TRANSFORMER_SQL_FILE = ConfigProperty

Review Comment:
   Fixed.



##########
hudi-common/src/main/java/org/apache/hudi/common/config/ConfigGroups.java:
##########
@@ -37,7 +37,8 @@ public enum Names {
     METRICS("Metrics Configs"),
     RECORD_PAYLOAD("Record Payload Config"),
     KAFKA_CONNECT("Kafka Connect Configs"),
-    AWS("Amazon Web Services Configs");
+    AWS("Amazon Web Services Configs"),
+    DELTA_STREAMER("DeltaStreamer Configs");

Review Comment:
   Done.  This line is still needed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8155:
URL: https://github.com/apache/hudi/pull/8155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8155: [HUDI-5781] Refactor SQL transformer configs to use HoodieConfig and ConfigProperty

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1472784538

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c24db5815366139661328e57619e44254393e147",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684",
       "triggerID" : "c24db5815366139661328e57619e44254393e147",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4b68aa73415424ed21cb5abe66d47756ed84d733",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4b68aa73415424ed21cb5abe66d47756ed84d733",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c24db5815366139661328e57619e44254393e147 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15684) 
   * 4b68aa73415424ed21cb5abe66d47756ed84d733 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8155:
URL: https://github.com/apache/hudi/pull/8155#issuecomment-1465578220

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c24db5815366139661328e57619e44254393e147",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c24db5815366139661328e57619e44254393e147",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c24db5815366139661328e57619e44254393e147 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #8155: [HUDI-5781] Refactor other classes to use HoodieConfig/ConfigProperty

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8155:
URL: https://github.com/apache/hudi/pull/8155#discussion_r1133461681


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieDeltaStreamerConfig.java:
##########
@@ -93,6 +93,16 @@ public class HoodieDeltaStreamerConfig extends HoodieConfig {
       .withDocumentation("The path to which a particular table is ingested. The config is specific to HoodieMultiTableDeltaStreamer"
           + " and overrides path determined using option `--base-path-prefix` for a table");
 
+  public static final ConfigProperty<String> TRANSFORMER_SQL_FILE = ConfigProperty

Review Comment:
   Let's add transformer configs into a separate config class `SqlTransformerConfig`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org