You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/05 18:14:30 UTC

[GitHub] [airflow] pgagnon commented on a change in pull request #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes

pgagnon commented on a change in pull request #4648: [AIRFLOW-3274] Add run_as_user and fs_group options for Kubernetes
URL: https://github.com/apache/airflow/pull/4648#discussion_r272693945
 
 

 ##########
 File path: airflow/contrib/kubernetes/kubernetes_request_factory/kubernetes_request_factory.py
 ##########
 @@ -199,7 +201,7 @@ def extract_tolerations(pod, req):
             req['spec']['tolerations'] = pod.tolerations
 
     @staticmethod
-    def extract_security_context(pod, req):
+    def extract_security_context(pod: Pod, req):
 
 Review comment:
   My bad. I forgot we still supported Python 2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services