[GitHub] [tvm-rfcs] areusch commented on a diff in pull request #87: Amend RFC0070 with DeclBuffer TVMScript syntax updates

[GitBox <gi...@apache.org>]

areusch commented on code in PR #87:
URL: https://github.com/apache/tvm-rfcs/pull/87#discussion_r943729451


##########
rfcs/0070-introducing-decl-buffer.md:
##########
@@ -146,9 +146,36 @@ Specifically, the updated flow of buffer flattening using `DeclBuffer` will be:
 with flattened indices.
 
 ## TVM script updates
+* New statement `T.decl_buffer` will be introduced. It has the same interface as `T.buffer_decl`.
+```python
+def decl_buffer(
+    shape: Sequence[Union[PrimExpr, int]],
+    dtype: str = "float32",
+    data: Var = None,

Review Comment:
   just one note--usually this is first if positional args are used (e.g. in the example above), is the order of these kwargs correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org