You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/16 08:26:00 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5403: fixing template argument if not specify values
fx19880617 opened a new pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403
`-values` will pass a null array instead of empty array. So need to do null check for `values` array.
Thanks to Manoj Singh for reporting this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#issuecomment-629614815
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=h1) Report
> Merging [#5403](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a&el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `69.55%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5403 +/- ##
==========================================
+ Coverage 66.44% 66.74% +0.29%
==========================================
Files 1075 1091 +16
Lines 54773 55785 +1012
Branches 8168 8365 +197
==========================================
+ Hits 36396 37235 +839
- Misses 15700 15797 +97
- Partials 2677 2753 +76
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `75.82% <0.00%> (-1.10%)` | :arrow_down: |
| [...pache/pinot/core/common/BlockMultiValIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmxvY2tNdWx0aVZhbEl0ZXJhdG9yLmphdmE=) | `14.28% <ø> (ø)` | |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `63.63% <ø> (ø)` | |
| [...aliterators/DictionaryBasedMultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...literators/DictionaryBasedSingleValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkU2luZ2xlVmFsdWVJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/operator/docvaliterators/MultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `56.25% <0.00%> (-25.57%)` | :arrow_down: |
| [...ava/org/apache/pinot/core/plan/FilterPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0ZpbHRlclBsYW5Ob2RlLmphdmE=) | `92.00% <ø> (ø)` | |
| [...ation/function/AggregationFunctionVisitorBase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVmlzaXRvckJhc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [235 more](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=footer). Last update [e682d49...778eb33](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Manoj-Singh-11 commented on a change in pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
Manoj-Singh-11 commented on a change in pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#discussion_r426132765
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/GroovyTemplateUtils.java
##########
@@ -57,6 +57,9 @@ public static String renderTemplate(String template, Map<String, Object> newCont
}
public static Map<String, Object> getTemplateContext(List<String> values) {
+ if (values == null) {
Review comment:
We should update IngestionJobLauncher.getSegmentGenerationJobSpec()
Line #57, if (context != null) {
propertiesMap.putAll(context);
}
We should check not null and empty. As you are passing empty map incase of values is null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#issuecomment-629614815
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=h1) Report
> Merging [#5403](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a&el=desc) will **decrease** coverage by `9.52%`.
> The diff coverage is `60.09%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5403 +/- ##
==========================================
- Coverage 66.44% 56.92% -9.53%
==========================================
Files 1075 1091 +16
Lines 54773 55785 +1012
Branches 8168 8365 +197
==========================================
- Hits 36396 31757 -4639
- Misses 15700 21516 +5816
+ Partials 2677 2512 -165
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/pinot/common/utils/FileUploadDownloadClient.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRmlsZVVwbG9hZERvd25sb2FkQ2xpZW50LmphdmE=) | `23.80% <0.00%> (-33.93%)` | :arrow_down: |
| [...er/api/resources/LLCSegmentCompletionHandlers.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0xMQ1NlZ21lbnRDb21wbGV0aW9uSGFuZGxlcnMuamF2YQ==) | `0.00% <0.00%> (-61.81%)` | :arrow_down: |
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `53.84% <0.00%> (-23.08%)` | :arrow_down: |
| [...pache/pinot/core/common/BlockMultiValIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmxvY2tNdWx0aVZhbEl0ZXJhdG9yLmphdmE=) | `14.28% <ø> (ø)` | |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...apache/pinot/core/data/function/JsonFunctions.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2Z1bmN0aW9uL0pzb25GdW5jdGlvbnMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==) | `0.00% <ø> (-80.00%)` | :arrow_down: |
| [...manager/realtime/HLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvSExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-82.16%)` | :arrow_down: |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `0.00% <ø> (-63.64%)` | :arrow_down: |
| [...aliterators/DictionaryBasedMultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [490 more](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=footer). Last update [e682d49...6a7c98f](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#issuecomment-629614815
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=h1) Report
> Merging [#5403](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a&el=desc) will **decrease** coverage by `20.66%`.
> The diff coverage is `47.07%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5403 +/- ##
===========================================
- Coverage 66.44% 45.78% -20.67%
===========================================
Files 1075 1091 +16
Lines 54773 55785 +1012
Branches 8168 8365 +197
===========================================
- Hits 36396 25542 -10854
- Misses 15700 28018 +12318
+ Partials 2677 2225 -452
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `71.42% <0.00%> (-5.50%)` | :arrow_down: |
| [...pache/pinot/core/common/BlockMultiValIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmxvY2tNdWx0aVZhbEl0ZXJhdG9yLmphdmE=) | `14.28% <ø> (ø)` | |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `63.63% <ø> (ø)` | |
| [...ache/pinot/core/data/table/SimpleIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1NpbXBsZUluZGV4ZWRUYWJsZS5qYXZh) | `0.00% <0.00%> (-94.83%)` | :arrow_down: |
| [...ore/minion/rollup/MergeRollupSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vcm9sbHVwL01lcmdlUm9sbHVwU2VnbWVudENvbnZlcnRlci5qYXZh) | `0.00% <ø> (-89.29%)` | :arrow_down: |
| [...aliterators/DictionaryBasedMultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...literators/DictionaryBasedSingleValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkU2luZ2xlVmFsdWVJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/operator/docvaliterators/MultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `56.25% <0.00%> (-25.57%)` | :arrow_down: |
| ... and [761 more](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=footer). Last update [e682d49...6a7c98f](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#issuecomment-629614815
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=h1) Report
> Merging [#5403](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a&el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `69.55%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5403 +/- ##
==========================================
+ Coverage 66.44% 66.74% +0.29%
==========================================
Files 1075 1091 +16
Lines 54773 55785 +1012
Branches 8168 8365 +197
==========================================
+ Hits 36396 37235 +839
- Misses 15700 15797 +97
- Partials 2677 2753 +76
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `75.82% <0.00%> (-1.10%)` | :arrow_down: |
| [...pache/pinot/core/common/BlockMultiValIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmxvY2tNdWx0aVZhbEl0ZXJhdG9yLmphdmE=) | `14.28% <ø> (ø)` | |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `63.63% <ø> (ø)` | |
| [...aliterators/DictionaryBasedMultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...literators/DictionaryBasedSingleValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvRGljdGlvbmFyeUJhc2VkU2luZ2xlVmFsdWVJdGVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/operator/docvaliterators/MultiValueIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2N2YWxpdGVyYXRvcnMvTXVsdGlWYWx1ZUl0ZXJhdG9yLmphdmE=) | `56.25% <0.00%> (-25.57%)` | :arrow_down: |
| [...ava/org/apache/pinot/core/plan/FilterPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0ZpbHRlclBsYW5Ob2RlLmphdmE=) | `92.00% <ø> (ø)` | |
| [...ation/function/AggregationFunctionVisitorBase.java](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVmlzaXRvckJhc2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [235 more](https://codecov.io/gh/apache/incubator-pinot/pull/5403/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=footer). Last update [e682d49...778eb33](https://codecov.io/gh/apache/incubator-pinot/pull/5403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#issuecomment-629615713
> can we add a test case
We can add scripts in quickstart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5403: fixing template argument if not specify values
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#discussion_r426137350
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/GroovyTemplateUtils.java
##########
@@ -57,6 +57,9 @@ public static String renderTemplate(String template, Map<String, Object> newCont
}
public static Map<String, Object> getTemplateContext(List<String> values) {
+ if (values == null) {
Review comment:
if `context` is an empty map, then `propertiesMap` won't change. This is just for NPE check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org