You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2017/04/03 08:33:51 UTC
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/2216
[ZEPPELIN-2336] Fix note reload on another note create/rename/remove
### What is this PR for?
This is to fix the issue with repeated note reload when some other note is created/renamed/removed
### What type of PR is it?
Bug Fix
### Todos
* [x] - don't initialise controller on note list update
### What is the Jira issue?
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)
### How should this be tested?
Described in [ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336),
also additional test from [ZEPPELIN-1145](https://issues.apache.org/jira/browse/ZEPPELIN-1145) would be nice
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2216
----
commit 23dae76ec0b26e7ffe5c9eaae1f4e33e1f10d300
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-04-03T08:27:42Z
remove init controller on note_info
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2216
@khalidhuseynov last commit in the master branch does not have test failure on second profile. Could you rebase and see if second profile passes?
Also this PR restores changes made in https://issues.apache.org/jira/browse/ZEPPELIN-1145. Should we reopen ZEPPELIN-1145 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
CI is green. i linked some of related issue in [ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2216
[ZEPPELIN-2336] Fix note reload on another note create/rename/remove
### What is this PR for?
This is to fix the issue with repeated note reload when some other note is created/renamed/removed
### What type of PR is it?
Bug Fix
### Todos
* [x] - don't initialise controller on note list update
### What is the Jira issue?
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)
### How should this be tested?
Described in [ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336),
also additional test from [ZEPPELIN-1145](https://issues.apache.org/jira/browse/ZEPPELIN-1145) would be nice
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2216
----
commit e53edc0db1b3314dc1cd606f2ab7d1d597836e53
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-04-03T08:27:42Z
remove init controller on note_info
commit 74543368768ae6f30bb8d8e3769fff5ffe3e4e26
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-04-04T07:09:19Z
fix js test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2216
LGTM
I think ZEPPELIN-2336 is quite serious issue.
Once CI becomes, let's merge this PR asap to master and branch-0.7 as a hotfix, and reopen ZEPPELIN-1145 for further investigation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
@Leemoonsoo i found some js tests failing in second profile, let me take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
@Leemoonsoo actually I couldn't reproduce ZEPPELIN-1145, but we can reopen it to make sure. maybe also /cc @r-kamath as original author
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2216
Merge to master and branch-0.7 as a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2216
[ZEPPELIN-2336] Fix note reload on another note create/rename/remove
### What is this PR for?
This is to fix the issue with repeated note reload when some other note is created/renamed/removed
### What type of PR is it?
Bug Fix
### Todos
* [x] - don't initialise controller on note list update
### What is the Jira issue?
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)
### How should this be tested?
Described in [ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336),
also additional test from [ZEPPELIN-1145](https://issues.apache.org/jira/browse/ZEPPELIN-1145) would be nice
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2216
----
commit b568a6c80faf5d4441b16de75214acddc55abed4
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-04-03T08:27:42Z
remove init controller on note_info
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:
https://github.com/apache/zeppelin/pull/2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2216
second profile keeps failing [here](https://travis-ci.org/khalidhuseynov/zeppelin/jobs/217983115). as i tried locally, getting following error
```
[ERROR] Failed to execute goal on project zeppelin-spark_2.10: Could not resolve dependencies for project org.apache.zeppelin:zeppelin-spark_2.10:jar:0.8.0-SNAPSHOT: Could not find artifact org.apache.zeppelin:zeppelin-display_2.11:jar:0.8.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
```
and as i checked in https://repository.apache.org/content/groups/snapshots/org/apache/zeppelin/zeppelin-display_2.11/, indeed there's no `0.8.0-SNAPSHOT`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...
Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/2216
[ZEPPELIN-2336] Fix note reload on another note create/rename/remove
### What is this PR for?
This is to fix the issue with repeated note reload when some other note is created/renamed/removed
### What type of PR is it?
Bug Fix
### Todos
* [x] - don't initialise controller on note list update
### What is the Jira issue?
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)
### How should this be tested?
Described in [ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336),
also additional test from [ZEPPELIN-1145](https://issues.apache.org/jira/browse/ZEPPELIN-1145) would be nice
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2336
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2216
----
commit b568a6c80faf5d4441b16de75214acddc55abed4
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2017-04-03T08:27:42Z
remove init controller on note_info
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---