You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Virag Kothari (JIRA)" <ji...@apache.org> on 2013/01/26 01:55:18 UTC
[jira] [Updated] (OOZIE-1131) CoordRerunXCommand.verifyPrecondition
modifies state since OOZIE-1065
[ https://issues.apache.org/jira/browse/OOZIE-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari updated OOZIE-1131:
---------------------------------
Fix Version/s: (was: 3.3.1)
(was: trunk)
> CoordRerunXCommand.verifyPrecondition modifies state since OOZIE-1065
> ---------------------------------------------------------------------
>
> Key: OOZIE-1131
> URL: https://issues.apache.org/jira/browse/OOZIE-1131
> Project: Oozie
> Issue Type: Bug
> Components: bundle
> Affects Versions: trunk, 3.3.1
> Reporter: Robert Kanter
>
> OOZIE-1065 adds the following, which calls a {{BundleStatusUpdateXCommand}}:
> {code}
> protected void verifyPrecondition() throws CommandException, PreconditionException {
> + BundleStatusUpdateXCommand bundleStatusUpdate = new BundleStatusUpdateXCommand(coordJob, coordJob.getStatus());
> if (coordJob.getStatus() == CoordinatorJob.Status.KILLED
> || coordJob.getStatus() == CoordinatorJob.Status.FAILED) {
> LOG.info("CoordRerunXCommand is not able to run, job status=" + coordJob.getStatus() + ", jobid=" + jobId);
> + // Call the parent so the pending flag is reset and state transition
> + // of bundle can happen
> + if (coordJob.getBundleId() != null) {
> + bundleStatusUpdate.call();
> + }
> throw new CommandException(ErrorCode.E1018,
> "coordinator job is killed or failed so all actions are not eligible to rerun!");
> }
> {code}
> {{verifyPrecondition()}} methods shouldn't modify state though
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira