You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2015/06/17 10:20:51 UTC
[GitHub] couchdb-fauxton pull request: Url fix
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/464
Url fix
THis is a fix for [COUCHDB-2717](https://issues.apache.org/jira/browse/COUCHDB-2717). It also sets the back button for all views and indexes to _all_docs instead of trying to keep a history.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton url-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/464.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #464
----
commit 4eee5375af35e15e494842a038c33c5b9f609e7b
Author: Garren Smith <ga...@gmail.com>
Date: 2015-06-16T13:59:50Z
Encode Url for document id
This fixes the issue of documents created with '\' causing the back
button to not work properly.
This fixes COUCHDB-2717
commit 45e693cf09fc038f75573c4877aba0a5f44a1d05
Author: Garren Smith <ga...@gmail.com>
Date: 2015-06-17T08:07:41Z
Always return to _all_docs
The '<' button now always returns the user to _all_docs when editing
views. This stops all the bugs of a user getting stuck in a view.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Url fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/464#issuecomment-113670123
Hey @garrensmith, I think the biggest usability problem with this fix is when the user is inside a View, clicks into a doc, then `<` back. Having them return to the _all_docs page is kinda crumby - and I vaguely remember that was the how it used to function a long time ago, which people complained about.
Since this is kind of a fringe case, perhaps an interim solution would be to add in a crude check in the helper method for the `\` char, then redirect back to the _all_docs for that only. Obviously pretty crap, but it'd buy us some time until we get the React Router up and running.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Url fix
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/464#issuecomment-114038653
@benkeen can you take another look. I've changed the behaviour. It now uses the history when a user is viewing a doc. But uses `_all_docs` when returning from a view. I think this is a pretty nice solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Url fix
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Url fix
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/464#issuecomment-114378463
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Url fix
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/464#issuecomment-114347046
Nice. Yeah, this works as I've expect. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---