You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/03 02:01:13 UTC

[GitHub] [tvm] kevinthesun commented on a change in pull request #7373: Add Support for aten::index

kevinthesun commented on a change in pull request #7373:
URL: https://github.com/apache/tvm/pull/7373#discussion_r569067836



##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -1855,6 +1855,34 @@ def one_hot(self, inputs, input_types):
     def index(self, inputs, input_types):
         data = inputs[0]
         indices = inputs[1]
+        indices_infered = self.infer_type(indices[0])

Review comment:
       I suggest enhancing relay and topi ```adv_index``` to support this, to be consistent with numpy style advanced indexing. It can be useful for other frontend as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org