You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "mike-mcgann (via GitHub)" <gi...@apache.org> on 2023/02/02 20:25:29 UTC
[GitHub] [daffodil] mike-mcgann commented on a diff in pull request #947: Add scalafmt (WIP)
mike-mcgann commented on code in PR #947:
URL: https://github.com/apache/daffodil/pull/947#discussion_r1095053179
##########
daffodil-cli/src/main/scala/org/apache/daffodil/InfosetTypes.scala:
##########
@@ -108,22 +108,22 @@ object InfosetType extends Enumeration {
forPerformance: Boolean): InfosetHandler = {
infosetType match {
- case InfosetType.EXI => EXIInfosetHandler(dataProcessor)
- case InfosetType.EXISA => EXIInfosetHandler(dataProcessor, schemaUri.get)
- case InfosetType.JDOM => JDOMInfosetHandler(dataProcessor)
- case InfosetType.JSON => JsonInfosetHandler(dataProcessor)
- case InfosetType.NULL => NULLInfosetHandler(dataProcessor)
- case InfosetType.SAX => SAXInfosetHandler(dataProcessor, forPerformance)
+ case InfosetType.EXI => EXIInfosetHandler(dataProcessor)
+ case InfosetType.EXISA => EXIInfosetHandler(dataProcessor, schemaUri.get)
+ case InfosetType.JDOM => JDOMInfosetHandler(dataProcessor)
+ case InfosetType.JSON => JsonInfosetHandler(dataProcessor)
+ case InfosetType.NULL => NULLInfosetHandler(dataProcessor)
+ case InfosetType.SAX => SAXInfosetHandler(dataProcessor, forPerformance)
case InfosetType.SCALA_XML => ScalaXMLInfosetHandler(dataProcessor)
- case InfosetType.W3CDOM => W3CDOMInfosetHandler(dataProcessor)
- case InfosetType.XML => XMLTextInfosetHandler(dataProcessor)
+ case InfosetType.W3CDOM => W3CDOMInfosetHandler(dataProcessor)
+ case InfosetType.XML => XMLTextInfosetHandler(dataProcessor)
Review Comment:
I personally like it. gofmt does the same with struct fields and makes everything look nice. You can omit whitespace changes in a github diff by clicking on the gear icon drop down, selecting "hide whitespace", and then clicking on apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org