[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2800: [GOBBLIN-933] add support for array of unions in json schema_new

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #2800: [GOBBLIN-933] add support for array of unions in json schema_new
URL: https://github.com/apache/incubator-gobblin/pull/2800#discussion_r343958627
 
 

 ##########
 File path: gobblin-core/src/main/java/org/apache/gobblin/converter/avro/JsonElementConversionWithAvroSchemaFactory.java
 ##########
 @@ -183,7 +189,7 @@ public Schema schema() {
     WorkUnitState state;
 
     public RecordConverter(String fieldName, boolean nullable, String sourceType, Schema schemaNode,
-        WorkUnitState state, List<String> ignoreFields) throws UnsupportedDateTypeException {
 
 Review comment:
   No. Just because inside this method, nothing will throw that exception. Seems like useless code so I remove it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services