[GitHub] nifi pull request #2584: NIFI-4388: Modules Not Honored

[bdesert <gi...@git.apache.org>]

GitHub user bdesert opened a pull request:

    https://github.com/apache/nifi/pull/2584

    NIFI-4388: Modules Not Honored

    Modules aren't honored. The bug is not reproducible in Jython (it handles modules with every script reload). But Groovy loads JARs and dirs with classes only on setup. Cannot provide test cases for Groovy, because it requires custom JARs to be provided as part of the package.
    -----
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdesert/nifi NIFI-4388_ISP_Modules_Reload

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2584
    
----
commit 0280f59a173e82df926acc9c6f50ef3b5302c9fa
Author: Ed <ed...@...>
Date:   2018-03-27T04:22:12Z

    NIFI-4388: Modules Not Honored
    
    Modules aren't honored. The bug is not reproducible in Jython (it handles modules with every script reload). But Groovy loads JARs and dirs with classes only on setup. Cannot provide test cases for Groovy, because it requires custom JARs to be provided as part of the package.

----


---

[GitHub] nifi issue #2584: NIFI-4388: Modules Not Honored

[mattyb149 <gi...@git.apache.org>]

Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/2584
  
    +1 LGTM, tested the fix and verified the modules are now being reloaded upon property value change. Thanks for the fix! Merging to master


---

[GitHub] nifi pull request #2584: NIFI-4388: Modules Not Honored

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2584


---