You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by keane <gi...@git.apache.org> on 2015/06/11 06:30:12 UTC
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
GitHub user keane opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26
fix warning on IOS8
After use Cordova build ios
there are some warning about UIDeviceOrientation and UIInterfaceOrientation:
Implicit conversion from enumeration type "UIDeviceOrientation"(aka "enum UIDeviceOrientation") to different enumeration type "UIInterfaceOrientation" (aka "enum UIInterfaceOrientation")
Based on current ios api, UIViewControl.interfaceOrientation has been deprecated.
Fixed those warning using function: [[UIDevice currentDevice] orientation] instead of self.viewController.interfaceOrientation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keane/cordova-plugin-statusbar master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 520bc4f7f7f5fb64f4db4002a4912370ab36f89b
Author: Kun Zhou <cl...@gmail.com>
Date: 2015-06-11T04:22:03Z
fix warning on IOS8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-142068241
Another pull request with all the iOS 7 warnings has been merged, this can be closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158222576
Oh, sorry, I'm talking about iOS 7 deprecated warnings, not iOS 8 warnings
Anyway, I already told that [[UIDevice currentDevice] orientation] isn't reliable, [[UIApplication sharedApplication] statusBarOrientation] should be used instead, I've assigned the issue to myself and I'll create a new pull request this weekend
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by S8ER01Z <gi...@git.apache.org>.
Github user S8ER01Z commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-130427802
Any chance of this change going in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by dangnelson <gi...@git.apache.org>.
Github user dangnelson commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-141490685
This really needs to be fixed. We're on iOS9 now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-111018380
using [[UIDevice currentDevice] orientation] is not reliable
maybe you can try with
[[UIApplication sharedApplication] statusBarOrientation], but it returns UIInterfaceOrientation too
Maybe you can just change the UIDeviceOrientationIsLandscape to UIInterfaceOrientationIsLandscape
Anyway, to get a pull request merged I think an issue on the cordova's JIRA page should exists in first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jordancardwell <gi...@git.apache.org>.
Github user jordancardwell commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158219287
Hey folks.. will this one get some love any time soon?
Just checking.. I updated to latest plugin version and thought it didn't actually update since I was still getting those deprecation warnings.
I also created a [JIRA issue](https://issues.apache.org/jira/browse/CB-10047) to maybe give some traction
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jordancardwell <gi...@git.apache.org>.
Github user jordancardwell commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158415705
@jcesarmobile awesome, thanks for the update... and yeah I didn't notice this was for previous deprecations.
But yeah I had updated through the add plugin command instead of the url. But I hadn't really considered using the repo directly, so good to know when I want to pull in the change.
thanks again :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158506196
I've sent the new pull request
https://github.com/apache/cordova-plugin-statusbar/pull/40
In fact, in the latest version on github, self.viewController.interfaceOrientation wasn't really used because invertFrameIfNeeded was using [[UIApplication sharedApplication] statusBarOrientation] and not the orientation passed as parameter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158220443
you updated from the github url? or just with a cordova plugin add cordova-plugin-statusbar?
I suppose you did the latest, because the warnings were fixed and the changes were merged some time ago, but the plugin hasn't been released yet, it's on the release proccess right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org