[GitHub] [doris] HappenLee commented on a diff in pull request #13339: [Opt](vec) opt runtime filter for TPCH Q22

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13339:
URL: https://github.com/apache/doris/pull/13339#discussion_r994432858


##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -435,9 +435,7 @@ class BloomFilterPredicate : public Predicate {
 
     std::shared_ptr<BloomFilterFuncBase> _filter;
     bool _has_calculate_filter = false;
-    // loop size must be power of 2
-    constexpr static int64_t _loop_size = 8192;
     // if filter rate less than this, bloom filter will set always true
-    constexpr static double _expect_filter_rate = 0.2;
+    constexpr static double _expect_filter_rate = 0.5;

Review Comment:
   forget to change it to 0.4, need change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org