[jira] Updated: (DERBY-2506) Adding the locator information to FD:OCA descriptor (FDODSC) andFD:OCA data (FDODTA) of the SQLDTA objects

["V.Narayanan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

V.Narayanan updated DERBY-2506:
-------------------------------

    Attachment: PreparedCallable_DRDA_v5.stat
                PreparedCallable_DRDA_v5.diff

Thanx a ton for the reviews and comments Rick.

Pls find some answers to the issues pointed.

>1) You have added some trace code to DRDAConnThread. Do you really want these tracesto be printed out >whenever we are running debug jars? Should these traces be enabled by some particular tracepoint? >Alternatively, is this just scaffolding which can be removed when you are done debugging this code?

I got the following extract from http://wiki.apache.org/db-derby/ProtocolDebuggingTips

Server SanityManager.DEBUG Output

With a sane build, you can set the derby property, derby.drda.debug=true. This will produce debug output on the server console which can be helpful in debugging protocol issues. This property also launches a thread which will print periodic memory usage information for the server jvm, so can be useful in debugging memory leaks as well. 

Also these traces exist for other Lid constant cases as well. 

>2) In NetStatementRequest.computeProtocolTypesAndLengths(), you are using the non-nullable DRDA types for >locators. All of the other cases in this switch statement are using the nullable DRDA types. If you are sure that >you should be using DRDA_TYPE_LOBLOC and DRDA_TYPE_CLOBLOC rather than DRDA_TYPE_NLOBLOC >and DRDA_TYPE_NCLOBLOC, could you include a comment explaining why the locator cases are different from >the other cases?

You are correct. These should have been Nullable. The patch attached addresses this issue. 

I am running tests on this patch and shall post the results as soon as the tests complete.

I request for this patch to be considered for reviews and comments.

Thanx again for the comments and review Rick.

> Adding the locator information to FD:OCA descriptor (FDODSC) andFD:OCA data (FDODTA)  of the SQLDTA objects
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-2506
>                 URL: https://issues.apache.org/jira/browse/DERBY-2506
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: V.Narayanan
>         Assigned To: V.Narayanan
>         Attachments: BlobLocatorTestProgram.java, PreparedCallable_DRDA_Test_diff.diff, PreparedCallable_DRDA_Test_diff.stat, PreparedCallable_DRDA_Test_diff_v3.diff, PreparedCallable_DRDA_Test_diff_v3.stat, PreparedCallable_DRDA_v1.diff, PreparedCallable_DRDA_v1.stat, PreparedCallable_DRDA_v2.diff, PreparedCallable_DRDA_v2.stat, PreparedCallable_DRDA_v3.diff, PreparedCallable_DRDA_v3.stat, PreparedCallable_DRDA_v4.diff, PreparedCallable_DRDA_v4.stat, PreparedCallable_DRDA_v5.diff, PreparedCallable_DRDA_v5.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.