You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jung JaeHwa <jh...@gruter.com> on 2014/02/24 14:01:09 UTC

Review Request 18422: TAJO-218: HiveQLAnalyzer has to support cast expression.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18422/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-218
    https://issues.apache.org/jira/browse/TAJO-218


Repository: tajo


Description
-------

We have to update HiveQLAnalyzer for cast expression.


Diffs
-----

  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java dd8c405 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java 240f082 
  tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.hiveql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.sql PRE-CREATION 

Diff: https://reviews.apache.org/r/18422/diff/


Testing
-------

mvn clean install


Thanks,

Jung JaeHwa


Re: Review Request 18422: TAJO-218: HiveQLAnalyzer has to support cast expression.

Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18422/#review35365
-----------------------------------------------------------

Ship it!


+1
The patch looks good for me.

- Hyunsik Choi


On Feb. 24, 2014, 10:01 p.m., Jung JaeHwa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18422/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 10:01 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-218
>     https://issues.apache.org/jira/browse/TAJO-218
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> We have to update HiveQLAnalyzer for cast expression.
> 
> 
> Diffs
> -----
> 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java dd8c405 
>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java 240f082 
>   tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.hiveql PRE-CREATION 
>   tajo-core/tajo-core-backend/src/test/resources/queries/default/select_15.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18422/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> 
> Thanks,
> 
> Jung JaeHwa
> 
>