You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by zh...@apache.org on 2016/11/01 11:16:08 UTC

kylin git commit: KYLIN-2114 remove builder dictionary config to cubeConfig

Repository: kylin
Updated Branches:
  refs/heads/master 4ca3cfea6 -> a2884f13c


KYLIN-2114 remove builder dictionary config to cubeConfig


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/a2884f13
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/a2884f13
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/a2884f13

Branch: refs/heads/master
Commit: a2884f13c22c0efe9a702b585af6c5404ef7d001
Parents: 4ca3cfe
Author: Jason <ji...@163.com>
Authored: Tue Nov 1 19:15:48 2016 +0800
Committer: Jason <ji...@163.com>
Committed: Tue Nov 1 19:15:48 2016 +0800

----------------------------------------------------------------------
 webapp/app/js/model/cubeConfig.js                       | 5 ++++-
 webapp/app/partials/cubeDesigner/advanced_settings.html | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/a2884f13/webapp/app/js/model/cubeConfig.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/model/cubeConfig.js b/webapp/app/js/model/cubeConfig.js
index a77ab4f..87413dc 100644
--- a/webapp/app/js/model/cubeConfig.js
+++ b/webapp/app/js/model/cubeConfig.js
@@ -104,5 +104,8 @@ KylinApp.constant('cubeConfig', {
   rowKeyShardOptions:[
     true,false
   ],
-  statusNeedNofity:['ERROR', 'DISCARDED', 'SUCCEED']
+  statusNeedNofity:['ERROR', 'DISCARDED', 'SUCCEED'],
+  buildDictionaries:[
+    {name:"Global Dictionary", value:"org.apache.kylin.dict.GlobalDictionaryBuilder"}
+  ]
 });

http://git-wip-us.apache.org/repos/asf/kylin/blob/a2884f13/webapp/app/partials/cubeDesigner/advanced_settings.html
----------------------------------------------------------------------
diff --git a/webapp/app/partials/cubeDesigner/advanced_settings.html b/webapp/app/partials/cubeDesigner/advanced_settings.html
index a1e3c80..0a9dc48 100755
--- a/webapp/app/partials/cubeDesigner/advanced_settings.html
+++ b/webapp/app/partials/cubeDesigner/advanced_settings.html
@@ -370,8 +370,8 @@
                      <div class="col-xs-12 col-sm-6">
                        <select class="form-control" chosen
                                ng-model="newDictionaries.builder"
+                               ng-options="item.value as item.name for item in cubeConfig.buildDictionaries"
                                required>
-                         <option value="org.apache.kylin.dict.GlobalDictionaryBuilder">Global Dictionary</option>
                          <option value="">-- Select a builder class--</option>
                        </select>
                      </div>