[jira] [Commented] (TEZ-572) Implement more efficient re-use for vertices that have no locality requirements,

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801545#comment-13801545 ] 

Bikas Saha commented on TEZ-572:
--------------------------------

NPE when the map returns null? We seem to be removing elements from the map in removeContainerRequest
{code}
+    Priority p = iter.next();
+    LocalityRequestCounter lrc = knownRequestsByPriority.get(p);
+    if (lrc.localityRequests.get() == 0) {
+      // Fallback to ANY if there are no pending requests that require
+      // locality matching
{code}



> Implement more efficient re-use for vertices that have no locality requirements,
> --------------------------------------------------------------------------------
>
>                 Key: TEZ-572
>                 URL: https://issues.apache.org/jira/browse/TEZ-572
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-572.1.patch
>
>
> Due to re-use locality delay, non-local matches have an inherent delay. For reduce vertices which define no locality requirements, this can be slow down assignment of containers.



--
This message was sent by Atlassian JIRA
(v6.1#6144)