You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/21 17:40:07 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #36904: [SPARK-39506][SQL] Make CacheTable, isCached, UncacheTable, setCurrentCatalog, currentCatalog, listCatalogs 3l namespace compatible

amaliujia commented on code in PR #36904:
URL: https://github.com/apache/spark/pull/36904#discussion_r902896484


##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala:
##########
@@ -26,6 +26,22 @@ import org.apache.spark.sql.catalyst.DefinedByConstructorParams
 // Note: all classes here are expected to be wrapped in Datasets and so must extend
 // DefinedByConstructorParams for the catalog to be able to create encoders for them.
 
+/**
+ * A catalog in Spark, as returned by the `listCatalogs` method defined in [[Catalog]].
+ *
+ * @param name name of the catalog
+ * @since 3.2.0
+ */
+class CatalogMetadata(
+    val name: String)

Review Comment:
   We might design the class like this 
   ```
   case class CatalogMetadata(
       name: String,
       description: String,
       owner: Option[String] = None,
       catalogType: Option[CatalogType] = None,
       createdAt: Option[Long] = None,
       createdBy: Option[String] = None,
       updatedAt: Option[Long] = None,
       updatedBy: Option[String] = None
   )
   ```
   
   However, I am not sure if there are extra information we can fetch for a catalog. Do you know if we have such rich metadata for a catalog in Spark?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org