[GitHub] [incubator-brpc] curoky commented on pull request #1121: THRIFT_STDCXX should be std when _THRIFT_STDCXX_H_ not define

[GitBox <gi...@apache.org>]

curoky commented on pull request #1121:
URL: https://github.com/apache/incubator-brpc/pull/1121#issuecomment-642673163


   > what if someone uses thrift whose version less than 0.13.0?
   
   Thrift add `_THRIFT_STDCXX_H_` after `0.10.0`, remove it from `0.13.0`.
   
   This means that users whose version <= `0.10.0` will fail to compile, but if we don't change it, all users whose version >= `0.13.0` will fail to compile.
   
   Maybe there is a better way to solve this problem which not need to change default behavior. For example, we can determine whether file `stdcxx.h` exists in cmake or bazel.
   
   But no matter what, we should make a change
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org