You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/03/10 16:30:44 UTC

[camel] 11/14: CAMEL-17763: cleaned up unused exceptions in camel-solr

This is an automated email from the ASF dual-hosted git repository.

orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 57b92f04ce1fe6b559fa0790d7c6b413a7e8ea96
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Thu Mar 10 15:43:27 2022 +0100

    CAMEL-17763: cleaned up unused exceptions in camel-solr
---
 .../java/org/apache/camel/component/solr/InitSolrEndpointTest.java  | 6 +++---
 .../test/java/org/apache/camel/component/solr/MapBodyManualIT.java  | 6 +++---
 .../org/apache/camel/component/solr/SolrComponentTestSupport.java   | 4 ++--
 .../java/org/apache/camel/component/solr/SolrServerMissingTest.java | 6 +++---
 .../test/java/org/apache/camel/component/solr/SolrTestSupport.java  | 2 +-
 .../org/apache/camel/component/solr/SolrUpdateAutocommitTest.java   | 4 ++--
 .../test/java/org/apache/camel/component/solr/SolrUpdateTest.java   | 4 ++--
 .../camel/component/solr/integration/SolrCloudProducerIT.java       | 4 ++--
 8 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/InitSolrEndpointTest.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/InitSolrEndpointTest.java
index d35d096..34ffb6c 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/InitSolrEndpointTest.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/InitSolrEndpointTest.java
@@ -41,7 +41,7 @@ public class InitSolrEndpointTest extends SolrTestSupport {
     private String solrUrl = "solr://localhost:" + getPort() + "/solr";
 
     @Test
-    public void endpointCreatedCorrectlyWithAllOptions() throws Exception {
+    public void endpointCreatedCorrectlyWithAllOptions() {
         HttpClient httpClient = HttpClientUtil.createClient(new ModifiableSolrParams());
         context.getRegistry().bind("http", httpClient);
         SolrClient httpSolrClient = new HttpSolrClient.Builder(solrUrl).build();
@@ -53,7 +53,7 @@ public class InitSolrEndpointTest extends SolrTestSupport {
     }
 
     @Test
-    public void streamingEndpointCreatedCorrectly() throws Exception {
+    public void streamingEndpointCreatedCorrectly() {
         SolrEndpoint solrEndpoint = context.getEndpoint(solrUrl, SolrEndpoint.class);
         assertNotNull(solrEndpoint);
         assertEquals(SolrConstants.DEFUALT_STREAMING_QUEUE_SIZE, solrEndpoint.getSolrConfiguration().getStreamingQueueSize(),
@@ -64,7 +64,7 @@ public class InitSolrEndpointTest extends SolrTestSupport {
     }
 
     @Test
-    public void wrongURLFormatFailsEndpointCreation() throws Exception {
+    public void wrongURLFormatFailsEndpointCreation() {
         assertThrows(ResolveEndpointFailedException.class,
                 () -> context.getEndpoint("solr://localhost:x99/solr"));
     }
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/MapBodyManualIT.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/MapBodyManualIT.java
index 41388a3..4a73534 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/MapBodyManualIT.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/MapBodyManualIT.java
@@ -47,7 +47,7 @@ public class MapBodyManualIT extends CamelTestSupport {
         template.send("direct:start", new Processor() {
 
             @Override
-            public void process(Exchange exchange) throws Exception {
+            public void process(Exchange exchange) {
                 Map<String, String> map = new HashMap<>();
                 map.put("id", "0553579923");
                 map.put("cat", "Test");
@@ -66,10 +66,10 @@ public class MapBodyManualIT extends CamelTestSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("direct:start").to("{{solr.address}}").to("mock:result");
             }
         };
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrComponentTestSupport.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrComponentTestSupport.java
index a7494eb..30ef7fb 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrComponentTestSupport.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrComponentTestSupport.java
@@ -99,10 +99,10 @@ public abstract class SolrComponentTestSupport extends SolrTestSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("direct:start").to(solrRouteUri());
                 from("direct:splitThenCommit")
                         .split(body())
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrServerMissingTest.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrServerMissingTest.java
index 95c593d..40c1451 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrServerMissingTest.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrServerMissingTest.java
@@ -25,7 +25,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
 public class SolrServerMissingTest extends SolrTestSupport {
 
     @Test
-    public void indexSingleDocumentToNonexistentServer() throws Exception {
+    public void indexSingleDocumentToNonexistentServer() {
         Exchange exchange = createExchangeWithBody(null);
         exchange.getIn().setHeader(SolrConstants.OPERATION, SolrConstants.OPERATION_INSERT);
         exchange.getIn().setHeader("SolrField.id", "MA147LL/A");
@@ -36,10 +36,10 @@ public class SolrServerMissingTest extends SolrTestSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("direct:start").to("solr://localhost:" + getPort() + "/missingSolr");
             }
         };
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrTestSupport.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrTestSupport.java
index 60f310b..0130f7d 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrTestSupport.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrTestSupport.java
@@ -26,7 +26,7 @@ public abstract class SolrTestSupport extends CamelTestSupport {
     private static int httpsPort;
 
     @BeforeAll
-    public static void initPort() throws Exception {
+    public static void initPort() {
         port = AvailablePortFinder.getNextAvailable();
         httpsPort = AvailablePortFinder.getNextAvailable();
         //TODO : add test for TLSv1.3
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateAutocommitTest.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateAutocommitTest.java
index 5ae96fb..303d4e8 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateAutocommitTest.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateAutocommitTest.java
@@ -145,7 +145,7 @@ public class SolrUpdateAutocommitTest extends SolrComponentTestSupport {
     }
 
     @Test
-    public void caughtSolrExceptionIsHandledElegantly() throws Exception {
+    public void caughtSolrExceptionIsHandledElegantly() {
         Exchange exchange = createExchangeWithBody(null);
         exchange.getIn().setHeader(SolrConstants.OPERATION, SolrConstants.OPERATION_INSERT);
         exchange.getIn().setHeader("SolrField.name", "Missing required field throws exception.");
@@ -245,7 +245,7 @@ public class SolrUpdateAutocommitTest extends SolrComponentTestSupport {
     }
 
     @Test
-    public void queryDocumentsToCSVUpdateHandlerWithoutParameters() throws Exception {
+    public void queryDocumentsToCSVUpdateHandlerWithoutParameters() {
         solrEndpoint.setRequestHandler("/update/csv");
 
         Exchange exchange = createExchangeWithBody(new File("src/test/resources/data/books.csv"));
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateTest.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateTest.java
index 0241d77..8e2b857 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateTest.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/SolrUpdateTest.java
@@ -154,7 +154,7 @@ public class SolrUpdateTest extends SolrComponentTestSupport {
     }
 
     @Test
-    public void caughtSolrExceptionIsHandledElegantly() throws Exception {
+    public void caughtSolrExceptionIsHandledElegantly() {
         Exchange exchange = createExchangeWithBody(null);
         exchange.getIn().setHeader(SolrConstants.OPERATION, SolrConstants.OPERATION_INSERT);
         exchange.getIn().setHeader("SolrField.name", "Missing required field throws exception.");
@@ -264,7 +264,7 @@ public class SolrUpdateTest extends SolrComponentTestSupport {
     }
 
     @Test
-    public void queryDocumentsToCSVUpdateHandlerWithoutParameters() throws Exception {
+    public void queryDocumentsToCSVUpdateHandlerWithoutParameters() {
         solrEndpoint.setRequestHandler("/update/csv");
 
         Exchange exchange = createExchangeWithBody(new File("src/test/resources/data/books.csv"));
diff --git a/components/camel-solr/src/test/java/org/apache/camel/component/solr/integration/SolrCloudProducerIT.java b/components/camel-solr/src/test/java/org/apache/camel/component/solr/integration/SolrCloudProducerIT.java
index 51c5bb3..56fe5d5 100644
--- a/components/camel-solr/src/test/java/org/apache/camel/component/solr/integration/SolrCloudProducerIT.java
+++ b/components/camel-solr/src/test/java/org/apache/camel/component/solr/integration/SolrCloudProducerIT.java
@@ -30,10 +30,10 @@ public class SolrCloudProducerIT extends SolrCloudITSupport {
     }
 
     @Override
-    protected RouteBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() {
         return new RouteBuilder() {
             @Override
-            public void configure() throws Exception {
+            public void configure() {
                 from("direct:send").to(solrEndpointUri);
             }
         };