You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by vesense <gi...@git.apache.org> on 2017/03/09 09:49:39 UTC
[GitHub] incubator-rocketmq pull request #74: HOTFIX: add a newline after help info
GitHub user vesense opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/74
HOTFIX: add a newline after help info
This is a very minor change. After execute command `sh mqadmin`, I get the last line info:
`See 'mqadmin help <command>' for more information on a specific command.[xinwang@hadoop bin]$`
Maybe we can improve this by adding a newline.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/incubator-rocketmq patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/74.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #74
----
commit 402676a497d87f17b5116a36c5fe719f1f017d52
Author: Xin Wang <be...@163.com>
Date: 2017-03-09T09:43:54Z
HOTFIX: add a newline after help info
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #74: HOTFIX: add a newline after help info
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/74
@zhouxinyu Thanks for your review. I filed a Jira for this and created a new PR for develop branch.
https://github.com/apache/incubator-rocketmq/pull/83
Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #74: HOTFIX: add a newline after help info
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/74
LGTM, thanks @vesense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #74: HOTFIX: add a newline after help info
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/74
Closed this. Moved to #83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #74: HOTFIX: add a newline after help info
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/74
[](https://coveralls.io/builds/10521377)
Changes Unknown when pulling **402676a497d87f17b5116a36c5fe719f1f017d52 on vesense:patch-1** into ** on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #74: HOTFIX: add a newline after help info
Posted by vesense <gi...@git.apache.org>.
Github user vesense closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #74: HOTFIX: add a newline after help info
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/74
[](https://coveralls.io/builds/10521377)
Changes Unknown when pulling **402676a497d87f17b5116a36c5fe719f1f017d52 on vesense:patch-1** into ** on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---