[jira] Updated: (TAPESTRY-450) ForBean can't restore a value from it's primary key when only "source" and "keyExpression" are given

["Marcus Brito (JIRA)" <ta...@jakarta.apache.org>]

     [ http://issues.apache.org/jira/browse/TAPESTRY-450?page=all ]

Marcus Brito updated TAPESTRY-450:
----------------------------------

    Attachment: forbean-minimal.diff

> ForBean can't restore a value from it's primary key when only "source" and "keyExpression" are given
> ----------------------------------------------------------------------------------------------------
>
>          Key: TAPESTRY-450
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-450
>      Project: Tapestry
>         Type: Bug
>   Components: Framework
>     Versions: 4.0
>  Environment: Tapestry 4.0-beta-3
>     Reporter: Marcus Brito
>  Attachments: forbean-minimal.diff, forbean.diff
>
> There's a bug on FormBean.getValueFromPrimaryKey() method that's preventing it from correctly restoring an object from the source collection if the user didn't supply a converter. The bug is just an unfortunate type, that resulted in a map lookup for the map itself :-)
> Attached goes two patches: forbean-minimal.diff is a "minimum changes" patch -- in *only* fixes the mentioned bug. forbean.diff fixes a few other (minor, stylistic) issues I've found when editing the affected class in IDEA: it fixes the mentioned bug, remove a couple of unused private methods, and inlines a local variable that's imediately returned -- feel free to pick which patch to apply.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org