You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/12/13 16:54:31 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1236
CLOUDSTACK-9158: Removed SLF4J, it's abundant due to log4j
In the entire project we use log4j, so why also use slf4j? I've removed slf4j and all references to it from the codebase.
Also I've let the top-level pom depend on log4j so not every project has to define it for itself.
Ping @remibergsma @DaanHoogland @miguelaferreira @wilderrodrigues @wido
Builds ok, running integration tests now!
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:33.329s
[INFO] Finished at: Sun Dec 13 16:53:55 CET 2015
[INFO] Final Memory: 104M/813M
[INFO] ------------------------------------------------------------------------
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9158
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1236
----
commit e7a6a0a38e36bc8deac7aa77b0aa624aa055bc1b
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-12-13T15:04:57Z
CLOUDSTACK-9158: Remove SLF4J, it's abundant due to log4j
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-164376707
@borisroman slf4j sits in a layer above log4j. I?m not sure about the particular case you are dealing with, however if we were using slf4j with log4j consistently it would be much easier to now move to logback (the successor of log4j). In thta case the code would be depending on the slf4j classes, and the implementation would be configurable (i.g. log4j, logback, other logging libs).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-173185634
Closing because of preference to logback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-164403037
@miguelaferreira good point. It looks like it has been added for that purpose but never actually used. So now we must choose: start using it or chop it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---