[GitHub] [hbase] Apache9 commented on a change in pull request #2310: HBASE-24898 Addendum to deal with Daylight Saving Time

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2310:
URL: https://github.com/apache/hbase/pull/2310#discussion_r476513292



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java
##########
@@ -37,7 +38,8 @@
     }
   }
 
-  private static Tick nextTick() {
+  @VisibleForTesting
+  protected static Tick nextTick() {

Review comment:
       Just remove the protected qualifier? We just want it to be package private right?

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java
##########
@@ -52,7 +54,8 @@ private static void moveToNextHour(Calendar calendar) {
     calendar.set(Calendar.MILLISECOND, 0);
   }
 
-  private static volatile Tick tick = nextTick();
+  @VisibleForTesting
+  protected static volatile Tick tick = nextTick();

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org