You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/11 08:06:45 UTC

[GitHub] [inlong] EMsnap opened a new pull request, #5486: [INLONG-5485][Sort] support json udf getter and json getter function in sort

EMsnap opened a new pull request, #5486:
URL: https://github.com/apache/inlong/pull/5486

   - Fixes #5485 
   
   ### Motivation
   
   [INLONG-5485][Sort] support json udf getter and json getter function in sort
   
   ### Modifications
   
   [INLONG-5485][Sort] support json udf getter and json getter function in sort
   
   ### Verifying this change
   
   run ut success
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] gong commented on pull request #5486: [INLONG-5485][Sort] Support JSON UDF getter and JSON getter function

Posted by GitBox <gi...@apache.org>.
gong commented on PR #5486:
URL: https://github.com/apache/inlong/pull/5486#issuecomment-1212674254

   Please `NativeFlinkSqlParser` register udf too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] thesumery commented on a diff in pull request #5486: [INLONG-5485][Sort] Support JSON UDF getter and JSON getter function

Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #5486:
URL: https://github.com/apache/inlong/pull/5486#discussion_r944069733


##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/function/JsonGetterFunctionTest.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.function;
+
+import java.util.ArrayList;
+import java.util.List;
+import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.test.util.AbstractTestBase;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.CloseableIterator;
+import org.apache.inlong.sort.formats.common.StringFormatInfo;
+import org.apache.inlong.sort.protocol.FieldInfo;
+import org.apache.inlong.sort.protocol.transformation.StringConstantParam;
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Test for {@link JsonGetterFunction}
+ */
+public class JsonGetterFunctionTest extends AbstractTestBase {
+
+    /**
+     * Test for JsonGetter function
+     *
+     * @throws Exception The exception may throw when test Encrypt function
+     */
+    @Test
+    public void testEncryptFunction() throws Exception {

Review Comment:
   please modify the function name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] EMsnap merged pull request #5486: [INLONG-5485][Sort] Support JSON UDF getter and JSON getter function

Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5486:
URL: https://github.com/apache/inlong/pull/5486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org