You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/17 16:52:40 UTC
[GitHub] [mynewt-nimble] sjanc opened a new pull request #774: nimble/test:
Fix stack corruption in ble_l2cap_test_coc_connect_multi
sjanc opened a new pull request #774: nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
URL: https://github.com/apache/mynewt-nimble/pull/774
struct ble_l2cap_sig_credit_base_connect_{req,rsp} are variable length
packets and we must provide storage for cids. This fix test failure on
MacOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #774:
nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #774: nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
URL: https://github.com/apache/mynewt-nimble/pull/774#issuecomment-600182162
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/test/src/ble_l2cap_test.c
<details>
```diff
@@ -776,7 +763,7 @@
ble_l2cap_test_util_init();
- ble_l2cap_test_util_create_conn(2, ((uint8_t[]){1,2,3,4,5,6}),
+ ble_l2cap_test_util_create_conn(2, ((uint8_t[]) {1,2,3,4,5,6}),
ble_l2cap_test_util_conn_cb, NULL);
for (i = 0; i < t->num; i++) {
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] sjanc merged pull request #774: nimble/test: Fix
stack corruption in ble_l2cap_test_coc_connect_multi
Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #774: nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
URL: https://github.com/apache/mynewt-nimble/pull/774
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #774:
nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #774: nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
URL: https://github.com/apache/mynewt-nimble/pull/774#issuecomment-600197574
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #774:
nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #774: nimble/test: Fix stack corruption in ble_l2cap_test_coc_connect_multi
URL: https://github.com/apache/mynewt-nimble/pull/774#issuecomment-600182162
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/test/src/ble_l2cap_test.c
<details>
```diff
@@ -776,7 +763,7 @@
ble_l2cap_test_util_init();
- ble_l2cap_test_util_create_conn(2, ((uint8_t[]){1,2,3,4,5,6}),
+ ble_l2cap_test_util_create_conn(2, ((uint8_t[]) {1,2,3,4,5,6}),
ble_l2cap_test_util_conn_cb, NULL);
for (i = 0; i < t->num; i++) {
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services