You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by to...@apache.org on 2019/11/22 20:22:37 UTC

[libcloud] branch trunk updated (e955b4d -> 9f2d8d6)

This is an automated email from the ASF dual-hosted git repository.

tomaz pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git.


    from e955b4d  Add changelog entry.
     new 202b86f  Fix Azure compute driver to allow adding maximum number of disks when LUN is unspecified
     new 2194488  Merge branch 'trunk' of https://github.com/palashgandhi/libcloud into palashgandhi-trunk
     new 9f2d8d6  Add changelog entry.

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CHANGES.rst                             | 9 +++++++++
 libcloud/compute/drivers/azure_arm.py   | 2 +-
 libcloud/test/compute/test_azure_arm.py | 9 +++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)


[libcloud] 01/03: Fix Azure compute driver to allow adding maximum number of disks when LUN is unspecified

Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git

commit 202b86fd2b1a44bae2f2a92a354f3f7e40b0b96b
Author: Palash Gandhi <pa...@delphix.com>
AuthorDate: Tue Nov 19 13:13:27 2019 -0800

    Fix Azure compute driver to allow adding maximum number of disks when LUN is unspecified
---
 libcloud/compute/drivers/azure_arm.py   | 2 +-
 libcloud/test/compute/test_azure_arm.py | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/libcloud/compute/drivers/azure_arm.py b/libcloud/compute/drivers/azure_arm.py
index e992f33..4a83dff 100644
--- a/libcloud/compute/drivers/azure_arm.py
+++ b/libcloud/compute/drivers/azure_arm.py
@@ -959,7 +959,7 @@ class AzureNodeDriver(NodeDriver):
         if ex_lun is None:
             # find the smallest unused logical unit number
             used_luns = [disk['lun'] for disk in disks]
-            free_luns = [lun for lun in range(0, 63) if lun not in used_luns]
+            free_luns = [lun for lun in range(0, 64) if lun not in used_luns]
             if len(free_luns) > 0:
                 ex_lun = free_luns[0]
             else:
diff --git a/libcloud/test/compute/test_azure_arm.py b/libcloud/test/compute/test_azure_arm.py
index 0f65d87..dcb21f2 100644
--- a/libcloud/test/compute/test_azure_arm.py
+++ b/libcloud/test/compute/test_azure_arm.py
@@ -432,6 +432,15 @@ class AzureNodeDriverTests(LibcloudTestCase):
         self.assertTrue(len(data_disks), len(volumes))
         self.assertTrue(set(luns), {0, 1, 15})
 
+        volumes = self.driver.list_volumes()
+        node = self.driver.list_nodes()[0]
+        for count in range(64):
+            self.driver.attach_volume(node, volumes[0])
+        data_disks = node.extra['properties']['storageProfile']['dataDisks']
+        luns = [disk['lun'] for disk in data_disks]
+        self.assertTrue(len(data_disks), 64)
+        self.assertTrue(set(luns), set(range(64)))
+
     def test_resize_volume(self):
         volume = self.driver.list_volumes()[0]
         original_size = volume.size


[libcloud] 02/03: Merge branch 'trunk' of https://github.com/palashgandhi/libcloud into palashgandhi-trunk

Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git

commit 219448868afea715e899f3cbeb4cd5ece2d9ea42
Merge: e955b4d 202b86f
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Fri Nov 22 21:16:46 2019 +0100

    Merge branch 'trunk' of https://github.com/palashgandhi/libcloud into palashgandhi-trunk

 libcloud/compute/drivers/azure_arm.py   | 2 +-
 libcloud/test/compute/test_azure_arm.py | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)


[libcloud] 03/03: Add changelog entry.

Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git

commit 9f2d8d64a352d65fd5096026fd11df07e24e27c7
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Fri Nov 22 21:18:58 2019 +0100

    Add changelog entry.
---
 CHANGES.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/CHANGES.rst b/CHANGES.rst
index 6b1117c..455fcc8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,15 @@ Common
   token. (GITHUB-1367)
   [kshtsk]
 
+Compute
+-------
+
+- [Azure ARM] Fix ``attach_volume`` method and allow maximum of 64 disks to be
+  added when LUN is not specified. Previously there was a bug and only a
+  maximum of 63 disks could be added.
+  (GITHUB-1372
+  [Palash Gandhi - @palashgandhi]
+
 Storage
 ~~~~~~~