You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/06 03:48:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4479: drivers/sdmmc: Remove rwbuffer to avoid panic
xiaoxiang781216 opened a new pull request #4479:
URL: https://github.com/apache/incubator-nuttx/pull/4479
## Summary
since rwbuffer isn't fully initiailized in mmcsd_slotinitialize.
BTW, if the cache is important for performance, it is better to implement a general block cache and put in a common location.
## Impact
Remove the unworked and unfinished code
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4479: drivers/sdmmc: Remove rwbuffer to avoid panic
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4479:
URL: https://github.com/apache/incubator-nuttx/pull/4479#issuecomment-913591996
@xiaomi-hujie instead of removing the feature, isn't an way to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #4479: drivers/sdmmc: Remove rwbuffer to avoid panic
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #4479:
URL: https://github.com/apache/incubator-nuttx/pull/4479#issuecomment-913591996
@xiaoxiang781216 instead of removing the feature, isn't an way to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4479: drivers/sdmmc: Remove rwbuffer to avoid panic
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4479:
URL: https://github.com/apache/incubator-nuttx/pull/4479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4479: drivers/sdmmc: Remove rwbuffer to avoid panic
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4479:
URL: https://github.com/apache/incubator-nuttx/pull/4479#issuecomment-913598536
> @xiaomi-hujie instead of removing the feature, isn't an way to fix it?
As the commit message note, it's better to do the cache in the common layer, like ftl or mtd_rwbuffer(e.g. blk_rwbuffer).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4479: drivers/sdmmc: Remove rwbuffer to avoid panic
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4479:
URL: https://github.com/apache/incubator-nuttx/pull/4479#issuecomment-913603143
> > @xiaomi-hujie instead of removing the feature, isn't an way to fix it?
>
> As the commit message note, it's better to do the cache in the common layer, like ftl or mtd_rwbuffer(e.g. blk_rwbuffer).
Ah ok! Got it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org