You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by zh...@apache.org on 2019/11/26 05:53:47 UTC
[carbondata] branch master updated: [HOTFIX] optimize java code
checkstyle for NoWhitespaceBefore rule
This is an automated email from the ASF dual-hosted git repository.
zhangzc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git
The following commit(s) were added to refs/heads/master by this push:
new 030f711 [HOTFIX] optimize java code checkstyle for NoWhitespaceBefore rule
030f711 is described below
commit 030f711d6c99bc3cdaf3fd491a5e02f66a87b1d8
Author: lamber-ken <la...@163.com>
AuthorDate: Tue Nov 26 10:26:43 2019 +0800
[HOTFIX] optimize java code checkstyle for NoWhitespaceBefore rule
optimize java code checkstyle for NoWhitespaceBefore rule
This closes #3482
---
dev/javastyle-config.xml | 2 +-
.../apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java | 2 +-
.../org/apache/carbondata/presto/CarbondataPageSourceProvider.java | 2 +-
.../java/org/apache/carbondata/streaming/StreamBlockletWriter.java | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/dev/javastyle-config.xml b/dev/javastyle-config.xml
index cfee020..6e84966 100644
--- a/dev/javastyle-config.xml
+++ b/dev/javastyle-config.xml
@@ -219,7 +219,7 @@
<!-- Checks for there is no whitespace before unary operators. -->
<module name="NoWhitespaceBefore">
- <property name="severity" value="info"/>
+ <property name="severity" value="error"/>
<property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/>
<property name="allowLineBreaks" value="true"/>
</module>
diff --git a/hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java b/hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
index c5097bb..b29d1b0 100644
--- a/hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
+++ b/hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java
@@ -194,7 +194,7 @@ public class CarbonVectorizedRecordReader extends AbstractRecordReader<Object> {
public Object getCurrentValue() throws IOException, InterruptedException {
rowCount += 1;
Object[] row = new Object[projectionMapping.size()];
- for (int i = 0; i < projectionMapping.size(); i ++) {
+ for (int i = 0; i < projectionMapping.size(); i++) {
// if projectionMapping.get(i) <i it means row is fetched already
if (projectionMapping.get(i) < i) {
row[i] = row[projectionMapping.get(i)];
diff --git a/integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java b/integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
index be088e1..1f646d9 100644
--- a/integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
+++ b/integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
@@ -53,7 +53,7 @@ import static com.google.common.base.Preconditions.checkNotNull;
public class CarbondataPageSourceProvider extends HivePageSourceProvider {
private CarbonTableReader carbonTableReader;
- private String queryId ;
+ private String queryId;
private HdfsEnvironment hdfsEnvironment;
@Inject public CarbondataPageSourceProvider(
diff --git a/streaming/src/main/java/org/apache/carbondata/streaming/StreamBlockletWriter.java b/streaming/src/main/java/org/apache/carbondata/streaming/StreamBlockletWriter.java
index c7d607a..89bf7c5 100644
--- a/streaming/src/main/java/org/apache/carbondata/streaming/StreamBlockletWriter.java
+++ b/streaming/src/main/java/org/apache/carbondata/streaming/StreamBlockletWriter.java
@@ -125,8 +125,8 @@ public class StreamBlockletWriter {
}
void skipRow() {
- maxSize -- ;
- maxRowNum -- ;
+ maxSize--;
+ maxRowNum--;
}
boolean isFull() {