You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/01/20 18:25:42 UTC
[jira] Created: (DERBY-840) International messages DatabaseMetaData
to GetFileInputStreamAction in org.apache.derby.client.am
International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
-------------------------------------------------------------------------------------------------
Key: DERBY-840
URL: http://issues.apache.org/jira/browse/DERBY-840
Project: Derby
Type: Sub-task
Reporter: David Van Couvering
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David W. Van Couvering" <Da...@Sun.COM>.
This is a mistake, I have not committed the patch for DERBY-840. I
checked in the fix where the jdbc4 tests did not build. Sorry for any
confusion.
David
David W. Van Couvering wrote:
> Hi, Narayanan. I have checked in the fix, revision 376770.
>
> David
>
> V.Narayanan (JIRA) wrote:
>
>> [
>> http://issues.apache.org/jira/browse/DERBY-840?page=comments#action_12365712
>> ]
>> V.Narayanan commented on DERBY-840:
>> -----------------------------------
>>
>> Thank You for the comments david. I will make the changes and submit
>> the patch again.
>> Narayanan
>>
>>
>>> International messages DatabaseMetaData to GetFileInputStreamAction
>>> in org.apache.derby.client.am
>>> -------------------------------------------------------------------------------------------------
>>>
>>>
>>> Key: DERBY-840
>>> URL: http://issues.apache.org/jira/browse/DERBY-840
>>> Project: Derby
>>> Type: Sub-task
>>> Components: Network Client
>>> Reporter: David Van Couvering
>>> Assignee: V.Narayanan
>>> Attachments: internationalization_840.diff,
>>> internationalization_840.stat
>>>
>>
>>
>>
Re: [jira] Commented: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David W. Van Couvering" <Da...@Sun.COM>.
Hi, Narayanan. I have checked in the fix, revision 376770.
David
V.Narayanan (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-840?page=comments#action_12365712 ]
>
> V.Narayanan commented on DERBY-840:
> -----------------------------------
>
> Thank You for the comments david. I will make the changes and submit the patch again.
> Narayanan
>
>
>>International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
>>-------------------------------------------------------------------------------------------------
>>
>> Key: DERBY-840
>> URL: http://issues.apache.org/jira/browse/DERBY-840
>> Project: Derby
>> Type: Sub-task
>> Components: Network Client
>> Reporter: David Van Couvering
>> Assignee: V.Narayanan
>> Attachments: internationalization_840.diff, internationalization_840.stat
>>
>
>
>
[jira] Commented: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "V.Narayanan (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=comments#action_12365712 ]
V.Narayanan commented on DERBY-840:
-----------------------------------
Thank You for the comments david. I will make the changes and submit the patch again.
Narayanan
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: V.Narayanan
> Attachments: internationalization_840.diff, internationalization_840.stat
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=comments#action_12365603 ]
David Van Couvering commented on DERBY-840:
-------------------------------------------
Hi, Narayanan. My apologies for losing track of this patch. Here are my comments
- TABLE_NAME_IS_NULL -- please change this message to "Table name can not be null."
- SECURITY_NO_SUCH_PROVIDER - please chain the underlying NoSuchProviderException
- SECURITY_NO_SUCH_ALGORITHM - please chain the underlying NoSuchAlgorithmException
- SECURITY_INVALID_ALGORITHM_PARAMETER - please chain the underlying InvalidAlgorithmParameterException
- SECURITY_INVALID_KEY - please chain the underlying InvalidKeyException
One thing you could do here is have a single message like "Security exception encountered, see next exception for details" and then chain the underlying security exception.
- SECURITY_WRONG_KEY_LENGTH - You are replacing two very different this for two very separate messages - "DES key has the wrong length" and 'sharedSecret key length error " + sharedSecret.length. I'd like to see this as two separate message ids, I am pretty sure the DES key and shared secret key are not the same, and the second message includes the length of the key as a parameter, which you have removed, and which might be very valuable information.
Thanks,
David
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: V.Narayanan
> Attachments: internationalization_840.diff, internationalization_840.stat
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-840) International messages DatabaseMetaData
to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "V.Narayanan (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
V.Narayanan updated DERBY-840:
------------------------------
Attachment: internationalization_840_1.diff
Hi,
I have made the changes. I am re-submitting the patch
Summary Of Changes
------------------------------------------
1) Changed TABLE_NAME_IS_NULL to TABLE_NAME_CANNOT_BE_NULL
2) I have chained the security exceptions. In order to do this I needed to call the SqlException contructor with the following arguments
(logWriter,messageId,null,cause). Instead of passing a null each time I introduced a constructor in the SqlException class with the signature
SqlException(LogWriter logWriter,Throwable cause,MessageId messageId).
I have introduced SECURITY_EXCEPTION_ENCOUNTERED and removed all the others and inside the message have added
"Security exception encountered, see next exception for details"
3) I have changed DES key has wrong length and Shared key length error to seperate messages.
thanx
Narayanan
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: V.Narayanan
> Attachments: internationalization_840.diff, internationalization_840.stat, internationalization_840_1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
David Van Couvering resolved DERBY-840:
---------------------------------------
Resolution: Fixed
Committed revision 378657
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: internationalization_840.diff, internationalization_840.stat, internationalization_840_1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=comments#action_12363849 ]
David Van Couvering commented on DERBY-840:
-------------------------------------------
When creating message ids for this subtask, please use the range XN100 - XN150
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-840) International messages DatabaseMetaData
to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
David Van Couvering closed DERBY-840:
-------------------------------------
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: internationalization_840.diff, internationalization_840.stat, internationalization_840_1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-840) International messages DatabaseMetaData
to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "V.Narayanan (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
V.Narayanan updated DERBY-840:
------------------------------
Attachment: internationalization_840.diff
internationalization_840.stat
Have used message id's XN100-XN150 in the patch.
thanx
Narayanan
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: V.Narayanan
> Attachments: internationalization_840.diff, internationalization_840.stat
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "V.Narayanan (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
V.Narayanan reassigned DERBY-840:
---------------------------------
Assign To: V.Narayanan
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: V.Narayanan
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-840) International messages DatabaseMetaData
to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
Mike Matrigali updated DERBY-840:
---------------------------------
Component: Network Client
Description:
Environment:
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-840) International messages
DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-840?page=all ]
David Van Couvering reassigned DERBY-840:
-----------------------------------------
Assign To: David Van Couvering (was: V.Narayanan)
> International messages DatabaseMetaData to GetFileInputStreamAction in org.apache.derby.client.am
> -------------------------------------------------------------------------------------------------
>
> Key: DERBY-840
> URL: http://issues.apache.org/jira/browse/DERBY-840
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: internationalization_840.diff, internationalization_840.stat, internationalization_840_1.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira