You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/31 21:56:52 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18835: fix installation widget missing contents
ys2843 opened a new pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835
## Description ##
fix #18833 . @ChaiBapchya Add following contents back to installation widget:
+ MacOS
+ gpu -> pip
+ gpu -> docker
+ cpu -> docker
+ Windows
+ cpu -> docker
+ gpu -> docker
### Changes ###
- [ ] Bring back missing installation guide contents
## Comments ##
- Preview: pending
@leezu Please review if above contents are valid, since they exist in codebase but was not linked into the website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-670636865
> Thank you @ys2843. Let's remove the windows docker instructions, as they only exist in the codebase due to a symlink but are not supported and shouldn't be shown on the website.
>
> I think the symlink would be removed as part of adding platform and version specific build from source instructions in #18666
Just to clarify, since we are going to have a unified installation widget that covers all versions. In which version we don't support `windows` and `docker`? Because if we still support them in previous versions, these symlink still need to be there. And we just hide `windows` and `docker` for some certain version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-670636865
> Thank you @ys2843. Let's remove the windows docker instructions, as they only exist in the codebase due to a symlink but are not supported and shouldn't be shown on the website.
>
> I think the symlink would be removed as part of adding platform and version specific build from source instructions in #18666
@leezu Just to clarify, since we are going to have a unified installation widget that covers all versions. In which version we don't support `windows` and `docker`? Because if we still support them in previous versions, these symlink still need to be there. And we just hide `windows` and `docker` for some certain version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-667410430
@mxnet-label-bot add [Website, pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-667702400
Jenkins CI successfully triggered : [unix-cpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-667410430
@mxnet-label-bot remove [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-667702385
@mxnet-bot run ci [unix-cpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-670636865
> Thank you @ys2843. Let's remove the windows docker instructions, as they only exist in the codebase due to a symlink but are not supported and shouldn't be shown on the website.
>
> I think the symlink would be removed as part of adding platform and version specific build from source instructions in #18666
@leezu Just to clarify, since we are going to have a unified installation widget that covers all versions. In which version we don't support `windows/docker`? Because if we still support them in previous versions, these symlink still need to be there. And we just hide `windows/docker` for some certain versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-668378788
Thanks @leezu good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-670636865
> Thank you @ys2843. Let's remove the windows docker instructions, as they only exist in the codebase due to a symlink but are not supported and shouldn't be shown on the website.
>
> I think the symlink would be removed as part of adding platform and version specific build from source instructions in #18666
@leezu Just to clarify, since we are going to have a unified installation widget that covers all versions. In which version we don't support `windows` and `docker`? Because if we still support them in previous versions, these symlink still need to be there. And we just hide `windows` and `docker` for some certain versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18835: fix installation widget missing contents
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18835:
URL: https://github.com/apache/incubator-mxnet/pull/18835#issuecomment-667403634
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, unix-cpu, edge, windows-gpu, windows-cpu, miscellaneous, sanity, clang, centos-cpu, unix-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org