You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "Yizhou-Yang (via GitHub)" <gi...@apache.org> on 2023/02/28 06:08:01 UTC
[GitHub] [inlong] Yizhou-Yang opened a new pull request, #7458: [INLONG-7457] [Sort] Change Doris changelog mode to capture update_before
Yizhou-Yang opened a new pull request, #7458:
URL: https://github.com/apache/inlong/pull/7458
### Prepare a Pull Request
- Fixes #7457
### Motivation
Doris needs to be consistent with other connectors in terms of changelog. After discussion, we think that changelog.all() is a better design than filtering update_before rowkinds.
### Modifications
change doris changelog mode to changelogmode.all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7458: [INLONG-7457][Sort] Change changelog mode to capture update_before for Doris
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7458:
URL: https://github.com/apache/inlong/pull/7458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #7458: [INLONG-7457][Sort] Change changelog mode to capture update_before for Doris, MySql and Oracle
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #7458:
URL: https://github.com/apache/inlong/pull/7458#discussion_r1119799201
##########
inlong-sort/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/table/OracleTableSource.java:
##########
@@ -107,12 +106,7 @@ public OracleTableSource(
@Override
public ChangelogMode getChangelogMode() {
- return ChangelogMode.newBuilder()
- .addContainedKind(RowKind.INSERT)
- .addContainedKind(RowKind.UPDATE_BEFORE)
- .addContainedKind(RowKind.UPDATE_AFTER)
- .addContainedKind(RowKind.DELETE)
- .build();
+ return ChangelogMode.all();
Review Comment:
this modification is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #7458: [INLONG-7457][Sort] Change changelog mode to capture update_before for Doris, MySql and Oracle
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #7458:
URL: https://github.com/apache/inlong/pull/7458#discussion_r1119798628
##########
inlong-sort/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/table/MySqlTableSource.java:
##########
@@ -226,13 +226,11 @@ public MySqlTableSource(
@Override
public ChangelogMode getChangelogMode() {
- final ChangelogMode.Builder builder =
- ChangelogMode.newBuilder().addContainedKind(RowKind.INSERT);
if (!appendSource) {
- builder.addContainedKind(RowKind.UPDATE_BEFORE)
- .addContainedKind(RowKind.UPDATE_AFTER)
- .addContainedKind(RowKind.DELETE);
+ return ChangelogMode.all();
}
+ final ChangelogMode.Builder builder =
+ ChangelogMode.newBuilder().addContainedKind(RowKind.INSERT);
Review Comment:
this modification is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org