You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "EslamAhmed171 (via GitHub)" <gi...@apache.org> on 2026/01/02 11:45:45 UTC
[PR] GH-46872: [C++][Python] Move Arange utility function to an Arrow C++ [arrow]
EslamAhmed171 opened a new pull request, #48710:
URL: https://github.com/apache/arrow/pull/48710
### Rationale for this change
Move the Arange utility function from Python-specific code to Arrow C++ core utilities.
### What changes are included in this PR?
Relocate the Arange implementation from `arrow/python/util.{h,cc}` to Arrow C++ utility files.
### Are these changes tested?
Yes, existing tests for `pa.arange` continues to pass.
### Are there any user-facing changes?
No user-facing changes. This is an internal code refactoring that maintains the existing `pyarrow.arange` API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46872: [C++][Python] Move Arange utility function to an Arrow C++ [arrow]
Posted by "EslamAhmed171 (via GitHub)" <gi...@apache.org>.
EslamAhmed171 commented on PR #48710:
URL: https://github.com/apache/arrow/pull/48710#issuecomment-4114465349
> It would be nice to add some C++ tests for this and cover edge cases as @alippai suggests.
Sorry for the late response, and thank you both for your reviews!
I have addressed both comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46872: [C++][Python] Move Arange utility function to an Arrow C++ [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #48710:
URL: https://github.com/apache/arrow/pull/48710#issuecomment-3708191244
Thanks for working on this @EslamAhmed171 !
It would be nice to add some C++ tests for this and cover edge cases as @alippai suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46872: [C++][Python] Move Arange utility function to an Arrow C++ [arrow]
Posted by "alippai (via GitHub)" <gi...@apache.org>.
alippai commented on PR #48710:
URL: https://github.com/apache/arrow/pull/48710#issuecomment-3707333420
Looks good, is there a need for handling pathological cases like skip == INT64_MIN and overflowing sizes here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46872: [C++][Python] Move Arange utility function to an Arrow C++ [arrow]
Posted by "EslamAhmed171 (via GitHub)" <gi...@apache.org>.
EslamAhmed171 commented on PR #48710:
URL: https://github.com/apache/arrow/pull/48710#issuecomment-4290265792
@rok Friendly ping!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org