You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/01/24 16:14:00 UTC
[jira] [Commented] (AIRFLOW-6628) Dag search autocomplete is
filtered by page context
[ https://issues.apache.org/jira/browse/AIRFLOW-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023059#comment-17023059 ]
ASF GitHub Bot commented on AIRFLOW-6628:
-----------------------------------------
robinedwards commented on pull request #7251: [AIRFLOW-6628] Fix search auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251
The auto complete on the dag search box utilises the page search context
which prevents auto completing dags which dont match the current query.
On the dags page with no search provided it executes a query that loads
every dag_id in the system to pass to the typeahead widget. On systems
with a lot of dags this makes the page large and slow.
Add a JSON endpoint to provide correct auto complete behaviour and
reduce page load time.
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Dag search autocomplete is filtered by page context
> ---------------------------------------------------
>
> Key: AIRFLOW-6628
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6628
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui, webserver
> Affects Versions: 2.0.0, 1.10.7, master
> Reporter: Robin Edwards
> Assignee: Robin Edwards
> Priority: Minor
>
> The auto complete on the dag search box utilises the page search context which prevents it auto completing dags which dont match the current query
> Further still on the home page with no search provided it executes a query that loads every dag_id in the system for it to be passed to the typeahead widget. On systems with a lot of dags this makes the page slow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)