You are viewing a plain text version of this content. The canonical link for it is here.

Posted to submarine-dev@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/18 16:08:06 UTC

[GitHub] [hadoop-submarine] pingsutw commented on a change in pull request #55: SUBMARINE-213. [SDK] Add pysubmarine-tracking example in mini-submarine

pingsutw commented on a change in pull request #55: SUBMARINE-213. [SDK] Add pysubmarine-tracking example in mini-submarine
URL: https://github.com/apache/hadoop-submarine/pull/55#discussion_r336566280
 
 

 ##########
 File path: submarine-sdk/pysubmarine/submarine/store/database/models.py
 ##########
 @@ -37,17 +37,17 @@
 class SqlMetric(Base):
     __tablename__ = 'metrics'
 
-    key = Column(String(250))
+    key = Column(String(190))
 
 Review comment:
   length 250 is too long for mariaDB in mini-submarine 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services