You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@deltaspike.apache.org by Markus Lachat <ma...@gmx.de> on 2016/01/12 11:08:11 UTC

DELTASPIKE-1044 breaks buttons that open PF dialogs

Hi,

I just tested the latest snapshot of DS and our GUI tests found that buttons
which are supposed to open a dialog, don't work any longer. We use
primefaces 5.3.4, older version also don't work. Switching back to DS 1.5.2
works. So I assume the fix for DELTASPIKE-1044 is the issue somehow!?

Button HTML output:
<input id="buttonOpenDialog" name="buttonOpenDialog" type="button"
value="Transfer Management" onclick="PF('transferDialog').show();"
title="Transfer Management" class="button">

Dialog to be displayed:
<div id="transferDialog" class="ui-dialog ui-widget ui-widget-content
ui-corner-all ui-shadow ui-hidden-container fieldsetContainer container_6
ui-draggable" role="dialog" aria-labelledby="transferManagerDialog_title"
</div>

If required I could also provide a demo for this.

BR,
Markus

Re: DELTASPIKE-1044 breaks buttons that open PF dialogs

Posted by Thomas Andraschko <an...@gmail.com>.

Hi,

I fixed it: https://issues.apache.org/jira/browse/DELTASPIKE-1063

2016-01-13 11:05 GMT+01:00 Markus Lachat <ma...@gmx.de>:

> Hi,
>
> My finding is now that commenting <ds:windowId/> re-enables the button.
> Here is a simple xhtml for copy & paste in your test. The windowMode must
> be ClientWindow and I used 1.5.3-SNAPSHOT from apache repo with PF 5.3
>
> <html xmlns="http://www.w3.org/1999/xhtml"
>       xmlns:h="http://java.sun.com/jsf/html"
>       xmlns:p="http://primefaces.org/ui"
>       xmlns:f="http://java.sun.com/jsf/core"
>       xmlns:ds="http://deltaspike.apache.org/jsf" >
>
> <h:head>
>     <title>JSF Button Dialog test</title>
> </h:head>
>
> <h:body>
>     <h:form id="form" prependId="false">
>         <ds:windowId/>
>                 <h:commandButton id="testButton" value="TestButton"
> type="button" onclick="PF('dlg1').show();" />
>                 <p:confirmDialog id="dlg1" header="Basic Dialog"
> widgetVar="dlg1" minHeight="40" modal="true">
>                         <h:commandButton type="submit"
> value="submitButton"/>
>                 <h:outputText value="Resistance to PrimeFaces is futile!"
> />
>         </p:confirmDialog>
>     </h:form>
>
> </h:body>
>
> </html>
>
> Thanks,
> Markus
>
> -----Ursprüngliche Nachricht-----
> Von: Thomas Andraschko [mailto:andraschko.thomas@gmail.com]
> Gesendet: Dienstag, 12. Januar 2016 11:12
> An: users@deltaspike.apache.org
> Betreff: Re: DELTASPIKE-1044 breaks buttons that open PF dialogs
>
> Hi,
>
> this should not be related as DELTASPIKE-1044 is only for <a> tags.
>
> It would be great if you could provide a small sample xhtml.
>
> Regards,
> Thomas
>
>

AW: DELTASPIKE-1044 breaks buttons that open PF dialogs

Posted by Markus Lachat <ma...@gmx.de>.

Hi,

My finding is now that commenting <ds:windowId/> re-enables the button. Here is a simple xhtml for copy & paste in your test. The windowMode must be ClientWindow and I used 1.5.3-SNAPSHOT from apache repo with PF 5.3

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://java.sun.com/jsf/html" 
      xmlns:p="http://primefaces.org/ui"
      xmlns:f="http://java.sun.com/jsf/core" 
      xmlns:ds="http://deltaspike.apache.org/jsf" >

<h:head>
    <title>JSF Button Dialog test</title>
</h:head>

<h:body>
    <h:form id="form" prependId="false">
    	<ds:windowId/>
        	<h:commandButton id="testButton" value="TestButton" type="button" onclick="PF('dlg1').show();" />
        	<p:confirmDialog id="dlg1" header="Basic Dialog" widgetVar="dlg1" minHeight="40" modal="true">
        		<h:commandButton type="submit" value="submitButton"/>
		<h:outputText value="Resistance to PrimeFaces is futile!" />
	</p:confirmDialog>
    </h:form>
    
</h:body>

</html>

Thanks,
Markus

-----Ursprüngliche Nachricht-----
Von: Thomas Andraschko [mailto:andraschko.thomas@gmail.com] 
Gesendet: Dienstag, 12. Januar 2016 11:12
An: users@deltaspike.apache.org
Betreff: Re: DELTASPIKE-1044 breaks buttons that open PF dialogs

Hi,

this should not be related as DELTASPIKE-1044 is only for <a> tags.

It would be great if you could provide a small sample xhtml.

Regards,
Thomas

Re: DELTASPIKE-1044 breaks buttons that open PF dialogs

Posted by Thomas Andraschko <an...@gmail.com>.

Hi,

this should not be related as DELTASPIKE-1044 is only for <a> tags.

It would be great if you could provide a small sample xhtml.

Regards,
Thomas