[GitHub] [pulsar] lovelle commented on issue #4062: Delayed message delivery implementation

[GitBox <gi...@apache.org>]

lovelle commented on issue #4062: Delayed message delivery implementation
URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484107066
 
 
   > Is that a bad thing? Is there any limitation in this approach?
   
   To me this is one of the best things about this pull, and absolutely not a bad thing.
   
   I still didn't take a deep look but my only concern would be, how will behave when very different range of delay arrive? Users sometimes makes an abusive use from this type of feature.
   
   The improvement I really like from this is that both features (this and #4062) uses a priority queue but this pull uses the buffer in direct memory :+1: 
   
   > Compress the priority queue, either by collapsing id ranges or by just passing the buffer through gzip.
   
   Since each adjacent message could have an arbitrary delay I can't see how collapsing by id range could be made.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services