You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by "orhankislal (via GitHub)" <gi...@apache.org> on 2023/08/31 10:09:55 UTC

[GitHub] [madlib] orhankislal opened a new pull request, #611: wip

orhankislal opened a new pull request, #611:
URL: https://github.com/apache/madlib/pull/611

   <!--  
   
   Thanks for sending a pull request!  Here are some tips for you:
   1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines
   2. Please Provide the Module Name, a JIRA Number and a short description about your changes.
   -->
   
   - [ ] Add the module name, JIRA# to PR/commit and description.
   - [ ] Add tests for the change. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] khannaekta commented on a diff in pull request #611: Build: Use PG15 in jenkins build

Posted by "khannaekta (via GitHub)" <gi...@apache.org>.
khannaekta commented on code in PR #611:
URL: https://github.com/apache/madlib/pull/611#discussion_r1315442416


##########
src/CMakeLists.txt:
##########
@@ -80,20 +80,20 @@ endif (NOT EIGEN_TAR_SOURCE)
 # specify an alternative path to the PyXB tarball:
 # -DPYXB_TAR_SOURCE=/path/to/PyXB-x.x.x.tar.gz
 
-set(PYXB_VERSION "1.2.6")
-set(PYXB_TAR_MD5 4303573fc7094ce4664c5b71cd4bdb48)
+# set(PYXB_VERSION "1.2.6")

Review Comment:
   do we want to keep this commented out or remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] khannaekta commented on a diff in pull request #611: Build: Use PG15 in jenkins build

Posted by "khannaekta (via GitHub)" <gi...@apache.org>.
khannaekta commented on code in PR #611:
URL: https://github.com/apache/madlib/pull/611#discussion_r1315442416


##########
src/CMakeLists.txt:
##########
@@ -80,20 +80,20 @@ endif (NOT EIGEN_TAR_SOURCE)
 # specify an alternative path to the PyXB tarball:
 # -DPYXB_TAR_SOURCE=/path/to/PyXB-x.x.x.tar.gz
 
-set(PYXB_VERSION "1.2.6")
-set(PYXB_TAR_MD5 4303573fc7094ce4664c5b71cd4bdb48)
+# set(PYXB_VERSION "1.2.6")

Review Comment:
   do we want to keep this commented out or remove it altogether.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] khannaekta commented on a diff in pull request #611: Build: Use PG15 in jenkins build

Posted by "khannaekta (via GitHub)" <gi...@apache.org>.
khannaekta commented on code in PR #611:
URL: https://github.com/apache/madlib/pull/611#discussion_r1315446532


##########
src/CMakeLists.txt:
##########
@@ -80,20 +80,20 @@ endif (NOT EIGEN_TAR_SOURCE)
 # specify an alternative path to the PyXB tarball:
 # -DPYXB_TAR_SOURCE=/path/to/PyXB-x.x.x.tar.gz
 
-set(PYXB_VERSION "1.2.6")
-set(PYXB_TAR_MD5 4303573fc7094ce4664c5b71cd4bdb48)
+# set(PYXB_VERSION "1.2.6")

Review Comment:
   we may need to update the [conflunce](https://cwiki.apache.org/confluence/display/MADLIB/Third+Party+Components) page too.
   Also, will this require any changes to the license file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] orhankislal merged pull request #611: Build: Use PG15 in jenkins build

Posted by "orhankislal (via GitHub)" <gi...@apache.org>.
orhankislal merged PR #611:
URL: https://github.com/apache/madlib/pull/611


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org