You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/09 20:40:28 UTC
[GitHub] [kafka] rondagostino opened a new pull request #9274: KAFKA-10131: Remove use_zk_connection flag
rondagostino opened a new pull request #9274:
URL: https://github.com/apache/kafka/pull/9274
Eliminate "use_zk_connection" and similarly-named flags in public system test methods. System tests should always use admin client when the broker supports it. We do need to bootstrap ACLs prior to Kafka starting or prior to enabling the
authorizer, so the ability to force the use of a direct ZooKeeper connection rather than the admin client still exists for this case.
This PR also converts a few methods in kafka.py that were connecting directly to ZooKeeper for leader and replica/ISR lists
to use the admin client when the broker version supports it. It also adds support for using the admin client when
performing "kafka-topics.sh ... -if-not-exists" which was added via KIP-604 in v2.6.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9274:
URL: https://github.com/apache/kafka/pull/9274#issuecomment-692361175
LGTM. Thanks, @rondagostino
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #9274: KAFKA-10131: Remove use_zk_connection flag
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #9274:
URL: https://github.com/apache/kafka/pull/9274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #9274:
URL: https://github.com/apache/kafka/pull/9274#issuecomment-689862257
@cmccabe Thanks for the review. I put the logic back into `kafka_acls.py`. Take a look and let me know if this is what you were thinking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rondagostino commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag
Posted by GitBox <gi...@apache.org>.
rondagostino commented on pull request #9274:
URL: https://github.com/apache/kafka/pull/9274#issuecomment-692271106
@cmccabe There were several test failures at first, so I pushed commit https://github.com/apache/kafka/pull/9274/commits/fb417ade01613dad8fa2574c4ea3484f3fa4e65f to fix them and reran the full system test suite. The results of this most recent run are at https://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-09-14--001.1600107441--rondagostino--KAFKA-10131--fb417ade0/report.txt:
```
====================================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.7.9
session_id: 2020-09-14--001
run time: 439 minutes 49.208 seconds
tests run: 684
passed: 513
failed: 1
ignored: 170
====================================================================================================
```
The one failure was due to an infrastructure issue:
```
test_id: kafkatest.tests.connect.connect_distributed_test.ConnectDistributedTest.test_restart_failed_connector.connect_protocol=sessioned
status: FAIL
run time: 8.720 seconds
Unable to open channel.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9274:
URL: https://github.com/apache/kafka/pull/9274#issuecomment-690623624
Looks good. LGTM pending a system test run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9274:
URL: https://github.com/apache/kafka/pull/9274#issuecomment-689824902
Thanks, @rondagostino . Is there any way to avoid moving the acls stuff out of `kafka_acls.py`? It seems nice to have some separation rather than having everything in `kafka.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org