You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/03/23 21:38:00 UTC

[jira] [Commented] (SOLR-16715) Replace new HashMap(int) and new HashSet(int) with CollectionUtil.newHashMap / CollectionUtil.newHashSet

    [ https://issues.apache.org/jira/browse/SOLR-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704369#comment-17704369 ] 

ASF subversion and git services commented on SOLR-16715:
--------------------------------------------------------

Commit 2375aa61679ee4c8e3b715e4168e8fb473ebb733 in solr's branch refs/heads/main from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=2375aa61679 ]

SOLR-16715: Replace new HashMap(int) and new HashSet(int) with CollectionUtil.newHashMap / CollectionUtil.newHashSet (#1482)



> Replace new HashMap(int) and new HashSet(int) with CollectionUtil.newHashMap / CollectionUtil.newHashSet
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-16715
>                 URL: https://issues.apache.org/jira/browse/SOLR-16715
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> While looking at replacing Guava, [~dsmiley] proposed converting existing new HashMap(int) and new HashSet(int) to avoid the trap of them not actually being that size.
> https://github.com/apache/solr/pull/1466#discussion_r1144811614
> We should be able to enforce this with ForbiddenAPIs and https://github.com/apache/solr/pull/1466 adds CollectionUtil inspired by Lucene that we can use.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org