You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/04/02 14:42:00 UTC
[jira] [Commented] (DRILL-7814) Add Limit Pushdown to MongoDB
Storage Plugin
[ https://issues.apache.org/jira/browse/DRILL-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313910#comment-17313910 ]
ASF GitHub Bot commented on DRILL-7814:
---------------------------------------
cgivre commented on pull request #2120:
URL: https://github.com/apache/drill/pull/2120#issuecomment-812559616
> @cgivre, looks like I've found the reason why the limit cannot be applied for the case you have pointed.
> Drill uses the `DrillPushLimitToScanRule` rule to push the limit to scan. This rule can be applied at the **logical** planning phase.
> Mongo storage plugin uses the `MongoPushDownFilterForScan` rule to push filter to scan. This rule is applied at the **physical** planning phase (in its constructor it passes `FilterPrel`and `ScanPrel` rel nodes to match).
>
> The solution for this issue is quite simple - update `MongoPushDownFilterForScan` to be able to work apply at any phase, for it, please replace `FilterPrel` with `org.apache.calcite.rel.core.Filter` and `ScanPrel` with `DrillScanRelBase`.
Hey @vvysotskyi, I tried doing this in the `MongoPushDownFilterForScan` and either I missed something, but I'm getting all kinds of errors when I did this. Could you take a quick look?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add Limit Pushdown to MongoDB Storage Plugin
> --------------------------------------------
>
> Key: DRILL-7814
> URL: https://issues.apache.org/jira/browse/DRILL-7814
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - MongoDB
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.19.0
>
>
> Drill's MongoDB plugin does not push limits down to Mongo. This PR adds this capability.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)