You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/13 16:28:36 UTC

[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #4764: Core: Add content and delete file counts to manifest tables

aokolnychyi commented on code in PR #4764:
URL: https://github.com/apache/iceberg/pull/4764#discussion_r872581760


##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -44,13 +44,17 @@
  */
 public class AllManifestsTable extends BaseMetadataTable {
   private static final Schema MANIFEST_FILE_SCHEMA = new Schema(
+      Types.NestedField.required(14, "content", Types.IntegerType.get()),

Review Comment:
   Using fresh IDs but adding columns in places where they make sense instead of adding to the end. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org