mod_autoindex/3770: IndexOptions None generates extraneous (garbage) data after file links

[in...@firstnethou.com]

>Number:         3770
>Category:       mod_autoindex
>Synopsis:       IndexOptions None generates extraneous (garbage) data after file links
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Tue Jan 26 06:30:00 PST 1999
>Last-Modified:
>Originator:     inkling@firstnethou.com
>Organization:
apache
>Release:        1.3.4
>Environment:
The failure occurred on Apache 1.3.3 and 1.3.4 on Linux and OS/2 compiles.
The distribution binaries from www.apache.org website were used for the OS/2
test. The source distribution was used for the Linux test; gcc version 2.7.2.3.
>Description:
Using IndexOptions None for very simple directory indices shows extraneous
(garbage) data following the </A> in the file links.  The bad data usually
looks like data from the access_log file, but could be anything.
PLEASE NOTE: It doesn't appear to occur in the Parent Directory link, or in
any of the Directory links, but rather only after the file links themselves.
It appears that when IndexOptions None the variable "pad" is used without being
initialized and/or allocated, thereby pointing to random data.
>How-To-Repeat:
In the httpd.conf file, set IndexOptions None
Browse around some directories and you will see garbage data following the
file links after jumping around a random number of directories(3-5).
>Fix:
Of course!!! :)  This patch is for Apache 1.3.4 source distribution:
Apply this patch to mod_autoindex.c (patchname mod_autoindex.c.diff)
1244c1244
<                     "</A>", pad, NULL);
---
>                     "</A>", NULL);
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]
[If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request ]
[from a developer.                                      ]
[Reply only with text; DO NOT SEND ATTACHMENTS!         ]