You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/18 20:38:55 UTC

Review Request 17093: Bug in http::request missing os::close.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17093/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 936f1181dc9e75c1d8faca60c905cfa01c87b77f 

Diff: https://reviews.apache.org/r/17093/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 17093: Bug in http::request missing os::close.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17093/#review32263
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Jan. 18, 2014, 7:38 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17093/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2014, 7:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 936f1181dc9e75c1d8faca60c905cfa01c87b77f 
> 
> Diff: https://reviews.apache.org/r/17093/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 17093: Bug in http::request missing os::close.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17093/#review32323
-----------------------------------------------------------

Ship it!


Looks like coverity found this too! :)

- Ben Mahler


On Jan. 18, 2014, 7:38 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17093/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2014, 7:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 936f1181dc9e75c1d8faca60c905cfa01c87b77f 
> 
> Diff: https://reviews.apache.org/r/17093/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>