You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2025/09/25 23:28:47 UTC
[PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
sadpandajoe opened a new pull request, #35298:
URL: https://github.com/apache/superset/pull/35298
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Documented the deprecation of APP_ICON configuration variable in favor of the new theme-based logo system introduced in PR #31590. This breaking change was causing confusion for users upgrading to Superset 6.0.0rc1 who found their custom logos no longer working.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "ahirner (via GitHub)" <gi...@apache.org>.
ahirner commented on PR #35298:
URL: https://github.com/apache/superset/pull/35298#issuecomment-3698660586
> seems APP_ICON still referenced in superset/config.py
Also in `superset/app.py` and `superset/views/base.py`. It's not clear how to proceed for logos with absolute URLs. Maybe that also needs #36058.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #35298:
URL: https://github.com/apache/superset/pull/35298#issuecomment-3893651211
## **Sequence Diagram**
This PR updates UPDATING.md to document that the legacy APP_ICON config is deprecated and the frontend now uses THEME_DEFAULT.token.brandLogoUrl for custom logos. The diagram shows the upgrade/migration success path and how the frontend resolves the logo.
```mermaid
sequenceDiagram
participant Admin
participant superset_config as "superset_config.py"
participant Frontend
Admin->>superset_config: Previously set APP_ICON = "/static/.../logo.png"
note right of superset_config: After PR 31590 APP_ICON is ignored
Admin->>superset_config: Replace with THEME_DEFAULT.token.brandLogoUrl
superset_config->>Frontend: Expose THEME_DEFAULT.token.brandLogoUrl
Frontend-->>Admin: Render custom logo from brandLogoUrl
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #35298:
URL: https://github.com/apache/superset/pull/35298#issuecomment-3336366158
> Oh seems APP_ICON still referenced in superset/config.py, probably want to wipe that config too.
Ok I can do it as part of this PR too and just change the UPDATING to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "scott-varadise (via GitHub)" <gi...@apache.org>.
scott-varadise commented on PR #35298:
URL: https://github.com/apache/superset/pull/35298#issuecomment-3336630812
A side note that currently `brandLogoUrl` in `superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx` doesn't include `SUPERSET_APP_ROOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35298:
URL: https://github.com/apache/superset/pull/35298#issuecomment-3893647940
rebased it for ya :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "scottyeung (via GitHub)" <gi...@apache.org>.
scottyeung commented on PR #35298:
URL: https://github.com/apache/superset/pull/35298#issuecomment-3336636975
A side note here, `brandLogoUrl` in `superset-frontend/packages/superset-ui-core/src/theme/Theme.tsx` doesn't include `SUPERSET_APP_ROOT`. It's working after I hardcoded the subpath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #35298: fix(docs): document APP_ICON deprecation in favor of theme-based brandLogoUrl
URL: https://github.com/apache/superset/pull/35298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org