You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/11/24 06:42:57 UTC
Re: Review Request 40524: Enabled resources.cpp and resources.hpp use
std::string
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/
-----------------------------------------------------------
(Updated 十一月 24, 2015, 5:42 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Summary (updated)
-----------------
Enabled resources.cpp and resources.hpp use std::string
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description
-------
Enabled resources.cpp and resources.hpp use std::string
Diffs (updated)
-----
include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40524/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40524: Enabled resources.cpp and resources.hpp use
std::string
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/#review107808
-----------------------------------------------------------
include/mesos/resources.hpp (lines 53 - 54)
<https://reviews.apache.org/r/40524/#comment167090>
This isn't allowed in a header. (We don't want the namespace(s) to be polluted with unnecessary aliases.)
include/mesos/v1/resources.hpp (lines 53 - 54)
<https://reviews.apache.org/r/40524/#comment167091>
Not allowed for the same reason above.
- Joseph Wu
On Nov. 23, 2015, 9:42 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40524/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:42 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled resources.cpp and resources.hpp use std::string
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d
> include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c
> src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
> src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
>
> Diff: https://reviews.apache.org/r/40524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40524: Used string directly in resources.cpp.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/#review108430
-----------------------------------------------------------
Ship it!
This is some nice code cleanup, but isn't related to optimistic offers.
Can you move it out of the review chain? (We can review/commit it quicker separately.)
- Joseph Wu
On Nov. 24, 2015, 10:41 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40524/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 10:41 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3955
> https://issues.apache.org/jira/browse/MESOS-3955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used string directly in resources.cpp.
>
>
> Diffs
> -----
>
> src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
> src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
>
> Diff: https://reviews.apache.org/r/40524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40524: Used string directly in resources.cpp.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/#review108736
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 1, 2015, 2:13 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40524/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used string directly in resources.cpp.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae
> src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
>
> Diff: https://reviews.apache.org/r/40524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40524: Used string directly in resources.cpp.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/#review108490
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40524]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 1, 2015, 2:13 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40524/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used string directly in resources.cpp.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae
> src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
>
> Diff: https://reviews.apache.org/r/40524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40524: Used string directly in resources.cpp.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/
-----------------------------------------------------------
(Updated 十二月 1, 2015, 2:13 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Repository: mesos
Description
-------
Used string directly in resources.cpp.
Diffs (updated)
-----
src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40524/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40524: Used string directly in resources.cpp.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/
-----------------------------------------------------------
(Updated 十一月 25, 2015, 6:41 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Summary (updated)
-----------------
Used string directly in resources.cpp.
Bugs: MESOS-3955
https://issues.apache.org/jira/browse/MESOS-3955
Repository: mesos
Description (updated)
-------
Used string directly in resources.cpp.
Diffs (updated)
-----
src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428
Diff: https://reviews.apache.org/r/40524/diff/
Testing
-------
Thanks,
Guangya Liu