You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/12/06 00:17:11 UTC
Review Request 54400: GEODE-2182: Possible race condition when
estimating index size and an entry is destroyed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54400/
-----------------------------------------------------------
Review request for geode, nabarun nag and Dan Smith.
Repository: geode
Description
-------
Returns max integer size so that this index ends up not being chosen if others are present. Not a good solution but gets past the possible stack trace issue. The better solution would be to eventually iterate through any remaining entries.
Diffs
-----
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java a8a38bd
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/MemoryIndexStore.java 3635897
geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexOnEntrySetJUnitTest.java 6034d53
Diff: https://reviews.apache.org/r/54400/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 54400: GEODE-2182: Possible race condition when
estimating index size and an entry is destroyed
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54400/#review158231
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Dec. 6, 2016, 12:17 a.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54400/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 12:17 a.m.)
>
>
> Review request for geode, nabarun nag and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Returns max integer size so that this index ends up not being chosen if others are present. Not a good solution but gets past the possible stack trace issue. The better solution would be to eventually iterate through any remaining entries.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java a8a38bd
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/MemoryIndexStore.java 3635897
> geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexOnEntrySetJUnitTest.java 6034d53
>
> Diff: https://reviews.apache.org/r/54400/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>