[GitHub] [incubator-superset] etr2460 commented on a change in pull request #7937: can not list tables after test connect success and explore button is always disable in query result view

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #7937: can not list tables after test connect success and explore button is always disable in query result view
URL: https://github.com/apache/incubator-superset/pull/7937#discussion_r308824997
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1727,7 +1727,8 @@ def testconn(self):
 
             with closing(engine.connect()) as conn:
                 conn.scalar(select([1]))
-                return json_success('"OK"')
+                return json_success(json.dumps(engine.table_names(), indent=4))
 
 Review comment:
   It's intentional that we don't dump the table names when testing the connection. This api shouldn't be used for anything more than making sure the connection to a db works

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org