[GitHub] [singa] chrishkchris commented on a change in pull request #587: SINGA-504 Add Gemm operator for autograd and onnx

[GitBox <gi...@apache.org>]

chrishkchris commented on a change in pull request #587: SINGA-504 Add Gemm operator for autograd and onnx
URL: https://github.com/apache/singa/pull/587#discussion_r373334627
 
 

 ##########
 File path: test/python/test_operation.py
 ##########
 @@ -2745,5 +2745,58 @@ def test_prelu_broadcast_cpu(self):
             np.testing.assert_array_almost_equal(tensor.to_numpy(tensor.from_raw_tensor(dx0)), grad0, decimal=5)
             np.testing.assert_array_almost_equal(tensor.to_numpy(tensor.from_raw_tensor(dx1)), grad1, decimal=5)
 
+    def test_gemm(self):
+        devs = [cpu_dev, gpu_dev]
 
 Review comment:
   > what if the machine does not have gpu?
   
   Yes, that's true.
   Last time I run the test_operation.py with USE_CUDA=0 in the master branch, the test_operation.py cannot run before removing the gpu_dev related things.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services