You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by godfreyhe <gi...@git.apache.org> on 2017/02/06 12:04:33 UTC

[GitHub] flink issue #3176: [FLINK-5571] [table] add open and close methods for UserD...

Github user godfreyhe commented on the issue:

    https://github.com/apache/flink/pull/3176
  
    Hi @wuchong , thanks for this review. 
    
    I think `UserDefinedScalarFunctionTest` is not enough, because `open` , `close` methods and job parameters are strongly depend on runtime, so it's better to test them in integration tests.
    
    I will add a test to verify Java ScalarFunction later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---